Reviewers: Kasper Lund, Description: Don't use -fomit-frame-pointer to build Mac V8. The Chrome crash reporting system can't currently process stacks produced by gcc -fomit-frame-pointer properly. The drawback outweighs the 2% performance improvement. Once the crash reporting system is able to handle this optimization, it should be revisited.
Please review this at http://codereview.chromium.org/173123 SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/ Affected files: M tools/gyp/v8.gyp Index: tools/gyp/v8.gyp =================================================================== --- tools/gyp/v8.gyp (revision 2732) +++ tools/gyp/v8.gyp (working copy) @@ -104,7 +104,6 @@ ['OS=="mac"', { 'xcode_settings': { 'GCC_OPTIMIZATION_LEVEL': '3', - 'OTHER_CFLAGS': [ '-fomit-frame-pointer' ], }, }], ['OS=="win"', { --~--~---------~--~----~------------~-------~--~----~ v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev -~----------~----~----~----~------~----~------~--~---
