Revision: 22970
Author: [email protected]
Date: Thu Aug 7 11:01:02 2014 UTC
Log: Remove dangerous default parameter from machine Store operator.
[email protected]
Review URL: https://codereview.chromium.org/451593002
http://code.google.com/p/v8/source/detail?r=22970
Modified:
/branches/bleeding_edge/src/compiler/machine-node-factory.h
/branches/bleeding_edge/src/compiler/machine-operator.h
/branches/bleeding_edge/test/cctest/compiler/test-changes-lowering.cc
/branches/bleeding_edge/test/cctest/compiler/test-machine-operator-reducer.cc
=======================================
--- /branches/bleeding_edge/src/compiler/machine-node-factory.h Mon Aug 4
08:18:37 2014 UTC
+++ /branches/bleeding_edge/src/compiler/machine-node-factory.h Thu Aug 7
11:01:02 2014 UTC
@@ -100,7 +100,7 @@
Store(rep, base, Int32Constant(0), value);
}
void Store(MachineRepresentation rep, Node* base, Node* index, Node*
value) {
- NEW_NODE_3(MACHINE()->Store(rep), base, index, value);
+ NEW_NODE_3(MACHINE()->Store(rep, kNoWriteBarrier), base, index, value);
}
// Arithmetic Operations.
Node* WordAnd(Node* a, Node* b) {
=======================================
--- /branches/bleeding_edge/src/compiler/machine-operator.h Fri Aug 1
12:18:20 2014 UTC
+++ /branches/bleeding_edge/src/compiler/machine-operator.h Thu Aug 7
11:01:02 2014 UTC
@@ -87,8 +87,7 @@
OP1(Load, MachineRepresentation, rep, Operator::kNoWrite, 2, 1);
}
// store [base + index], value
- Operator* Store(MachineRepresentation rep,
- WriteBarrierKind kind = kNoWriteBarrier) {
+ Operator* Store(MachineRepresentation rep, WriteBarrierKind kind) {
StoreRepresentation store_rep = {rep, kind};
OP1(Store, StoreRepresentation, store_rep, Operator::kNoRead, 3, 0);
}
=======================================
--- /branches/bleeding_edge/test/cctest/compiler/test-changes-lowering.cc
Fri Aug 1 08:38:16 2014 UTC
+++ /branches/bleeding_edge/test/cctest/compiler/test-changes-lowering.cc
Thu Aug 7 11:01:02 2014 UTC
@@ -213,7 +213,8 @@
double result;
t.BuildStoreAndLower(t.simplified()->ChangeTaggedToFloat64(),
- t.machine()->Store(kMachineFloat64), &result);
+ t.machine()->Store(kMachineFloat64,
kNoWriteBarrier),
+ &result);
if (Pipeline::SupportedTarget()) {
FOR_INT32_INPUTS(i) {
=======================================
---
/branches/bleeding_edge/test/cctest/compiler/test-machine-operator-reducer.cc
Tue Aug 5 08:47:39 2014 UTC
+++
/branches/bleeding_edge/test/cctest/compiler/test-machine-operator-reducer.cc
Thu Aug 7 11:01:02 2014 UTC
@@ -639,8 +639,8 @@
}
{
- Node* store =
- R.graph.NewNode(R.machine.Store(kMachineWord32), base, index,
load);
+ Node* store = R.graph.NewNode(
+ R.machine.Store(kMachineWord32, kNoWriteBarrier), base, index,
load);
MachineOperatorReducer reducer(&R.graph);
Reduction reduction = reducer.Reduce(store);
CHECK(!reduction.Changed()); // stores should not be reduced.
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
