On 2014/08/07 14:10:03, rossberg wrote:
LGTM, except that the relevant tests should move to the mjsunit/es6
directory
now.
Humm, moving the tests there causes them to fail, as that directory is run
with
--always-opt --turbo-filter=*. Example failing test program under those
flags
(which works fine otherwise):
function wrap_iterator(iterator) {
var iterable = {};
iterable[Symbol.iterator] = function() { return iterator; };
return iterable;
}
function integers_until(max) {
function next() {
var ret = { value: this.n, done: this.n == max };
this.n++;
return ret;
}
return wrap_iterator({ next: next, n: 0 });
}
function fold(cons, seed, iterable) {
for (var x of iterable) {
seed = cons(x, seed);
}
return seed;
}
function sum(x, tail) {
return x + tail;
}
if (fold(sum, 0, integers_until(10)) != 45) throw "wat";
Could it be something about the bailout id's again? For-of isn't
crankshafted
so they might not be used at all currently. It could just be a bug in TF,
of
course. Should I figure out the issue before landing this, or land and
figure
it out later?
https://codereview.chromium.org/446023002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
