[v8-dev] Fix debug-promises tests. (issue 455683002 by [email protected])

Fri, 08 Aug 2014 00:37:37 -0700 

Reviewers: rossberg,

Description:
Fix debug-promises tests.

Using assertEquals on two Promises always passes. Use assertSame instead.

[email protected]

Please review this at https://codereview.chromium.org/455683002/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+9, -11 lines):
  M test/mjsunit/es6/debug-promises/reject-caught-all.js
  M test/mjsunit/es6/debug-promises/reject-uncaught-all.js
  M test/mjsunit/es6/debug-promises/reject-uncaught-late.js
  M test/mjsunit/es6/debug-promises/reject-uncaught-uncaught.js
  M test/mjsunit/es6/debug-promises/reject-with-invalid-reject.js
  M test/mjsunit/es6/debug-promises/reject-with-undefined-reject.js
  M test/mjsunit/es6/debug-promises/throw-caught-all.js
  M test/mjsunit/es6/debug-promises/throw-uncaught-all.js
  M test/mjsunit/es6/debug-promises/throw-uncaught-uncaught.js
  M test/mjsunit/es6/debug-promises/throw-with-throw-in-reject.js
  M test/mjsunit/es6/debug-promises/throw-with-undefined-reject.js


Index: test/mjsunit/es6/debug-promises/reject-caught-all.js
diff --git a/test/mjsunit/es6/debug-promises/reject-caught-all.js b/test/mjsunit/es6/debug-promises/reject-caught-all.js index 5a42516f39b91ecf9c23f71267985b27201eb2a1..0fca57730a1430be493d7964cda0c1c18b93fb45 100644 
--- a/test/mjsunit/es6/debug-promises/reject-caught-all.js
+++ b/test/mjsunit/es6/debug-promises/reject-caught-all.js
@@ -36,7 +36,7 @@ function listener(event, exec_state, event_data, data) {
       expected_events--;
       assertTrue(expected_events >= 0);
       assertEquals("reject", event_data.exception().message);
-      assertEquals(q, event_data.promise());
+      assertSame(q, event_data.promise());
       assertFalse(event_data.uncaught());
     }
   } catch (e) {
Index: test/mjsunit/es6/debug-promises/reject-uncaught-all.js
diff --git a/test/mjsunit/es6/debug-promises/reject-uncaught-all.js b/test/mjsunit/es6/debug-promises/reject-uncaught-all.js index 16bc2ce03eb82c227d7ed6e715002fc37922a0fb..beaf1878fef9943721a3659be876bd5e06bebad3 100644 
--- a/test/mjsunit/es6/debug-promises/reject-uncaught-all.js
+++ b/test/mjsunit/es6/debug-promises/reject-uncaught-all.js
@@ -31,7 +31,7 @@ function listener(event, exec_state, event_data, data) {
       assertTrue(expected_events >= 0);
       assertEquals("uncaught reject", event_data.exception().message);
       assertTrue(event_data.promise() instanceof Promise);
-      assertEquals(q, event_data.promise());
+      assertSame(q, event_data.promise());
       assertTrue(event_data.uncaught());
       // All of the frames on the stack are from native Javascript.
       assertEquals(0, exec_state.frameCount());
Index: test/mjsunit/es6/debug-promises/reject-uncaught-late.js
diff --git a/test/mjsunit/es6/debug-promises/reject-uncaught-late.js b/test/mjsunit/es6/debug-promises/reject-uncaught-late.js index b46fa06d1a78ada972e2af2ef801d36cc1e23f32..4a883da13a793972d00fd2f4a9f8311b15b04811 100644 
--- a/test/mjsunit/es6/debug-promises/reject-uncaught-late.js
+++ b/test/mjsunit/es6/debug-promises/reject-uncaught-late.js
@@ -38,7 +38,7 @@ function listener(event, exec_state, event_data, data) {
       assertTrue(expected_events >= 0);
       assertEquals("uncaught reject p", event_data.exception().message);
       assertTrue(event_data.promise() instanceof Promise);
-      assertEquals(p, event_data.promise());
+      assertSame(p, event_data.promise());
       assertTrue(event_data.uncaught());
       // Assert that the debug event is triggered at the throw site.
assertTrue(exec_state.frame(0).sourceLineText().indexOf("// event") 
0);

Index: test/mjsunit/es6/debug-promises/reject-uncaught-uncaught.js
diff --git a/test/mjsunit/es6/debug-promises/reject-uncaught-uncaught.js b/test/mjsunit/es6/debug-promises/reject-uncaught-uncaught.js index 364217ca306ca44109caaec1b90c197909c27755..86e2a815e7257360e1995b50b6e39d9da8d583c4 100644 
--- a/test/mjsunit/es6/debug-promises/reject-uncaught-uncaught.js
+++ b/test/mjsunit/es6/debug-promises/reject-uncaught-uncaught.js
@@ -31,7 +31,7 @@ function listener(event, exec_state, event_data, data) {
       assertTrue(expected_events >= 0);
       assertEquals("uncaught reject", event_data.exception().message);
       assertTrue(event_data.promise() instanceof Promise);
-      assertEquals(q, event_data.promise());
+      assertSame(q, event_data.promise());
       assertTrue(event_data.uncaught());
       // All of the frames on the stack are from native Javascript.
       assertEquals(0, exec_state.frameCount());
Index: test/mjsunit/es6/debug-promises/reject-with-invalid-reject.js
diff --git a/test/mjsunit/es6/debug-promises/reject-with-invalid-reject.js b/test/mjsunit/es6/debug-promises/reject-with-invalid-reject.js index 40f32ef95e9028a8bf4466ba7f60020a4df0517d..fc6233da8d15e99a72de26147251df207289200b 100644 
--- a/test/mjsunit/es6/debug-promises/reject-with-invalid-reject.js
+++ b/test/mjsunit/es6/debug-promises/reject-with-invalid-reject.js
@@ -42,7 +42,6 @@ function listener(event, exec_state, event_data, data) {
assertEquals("number is not a function", event_data.exception().message); 
       // All of the frames on the stack are from native Javascript.
       assertEquals(0, exec_state.frameCount());
-      assertEquals(q, event_data.promise());
     }
   } catch (e) {
     %AbortJS(e + "\n" + e.stack);
Index: test/mjsunit/es6/debug-promises/reject-with-undefined-reject.js
diff --git a/test/mjsunit/es6/debug-promises/reject-with-undefined-reject.js b/test/mjsunit/es6/debug-promises/reject-with-undefined-reject.js index 39dabcf113d13e094bd417848b544fa22ac8758e..d11c01ff73b6216cab278aa850e7fa45c49cf2d8 100644 
--- a/test/mjsunit/es6/debug-promises/reject-with-undefined-reject.js
+++ b/test/mjsunit/es6/debug-promises/reject-with-undefined-reject.js
@@ -42,7 +42,6 @@ function listener(event, exec_state, event_data, data) {
       assertEquals("caught", event_data.exception().message);
       // All of the frames on the stack are from native Javascript.
       assertEquals(0, exec_state.frameCount());
-      assertEquals(q, event_data.promise());
     }
   } catch (e) {
     %AbortJS(e + "\n" + e.stack);
Index: test/mjsunit/es6/debug-promises/throw-caught-all.js
diff --git a/test/mjsunit/es6/debug-promises/throw-caught-all.js b/test/mjsunit/es6/debug-promises/throw-caught-all.js index 053c0c2842ebcbafa8d406a9548d6e33d780da40..2fbf05141d56d018f3115a8a5e82b8cfcd709b43 100644 
--- a/test/mjsunit/es6/debug-promises/throw-caught-all.js
+++ b/test/mjsunit/es6/debug-promises/throw-caught-all.js
@@ -35,7 +35,7 @@ function listener(event, exec_state, event_data, data) {
       expected_events--;
       assertTrue(expected_events >= 0);
       assertEquals("caught", event_data.exception().message);
-      assertEquals(q, event_data.promise());
+      assertSame(q, event_data.promise());
       assertFalse(event_data.uncaught());
     }
   } catch (e) {
Index: test/mjsunit/es6/debug-promises/throw-uncaught-all.js
diff --git a/test/mjsunit/es6/debug-promises/throw-uncaught-all.js b/test/mjsunit/es6/debug-promises/throw-uncaught-all.js index 7552589fa72c13160f9b55fc6c6552e4115b88b5..72f800bf5b3017b66a52f879260845448c1dd59a 100644 
--- a/test/mjsunit/es6/debug-promises/throw-uncaught-all.js
+++ b/test/mjsunit/es6/debug-promises/throw-uncaught-all.js
@@ -32,7 +32,7 @@ function listener(event, exec_state, event_data, data) {
       assertTrue(expected_events >= 0);
       assertEquals("uncaught", event_data.exception().message);
       assertTrue(event_data.promise() instanceof Promise);
-      assertEquals(q, event_data.promise());
+      assertSame(q, event_data.promise());
       assertTrue(event_data.uncaught());
       // Assert that the debug event is triggered at the throw site.
assertTrue(exec_state.frame(0).sourceLineText().indexOf("// event") 
0);

Index: test/mjsunit/es6/debug-promises/throw-uncaught-uncaught.js
diff --git a/test/mjsunit/es6/debug-promises/throw-uncaught-uncaught.js b/test/mjsunit/es6/debug-promises/throw-uncaught-uncaught.js index 45e7e0db849a198008bb000a37b2e3037f57ddc7..69aa8ebbd248c2e6fd01770aca7b47126526ce53 100644 
--- a/test/mjsunit/es6/debug-promises/throw-uncaught-uncaught.js
+++ b/test/mjsunit/es6/debug-promises/throw-uncaught-uncaught.js
@@ -32,7 +32,7 @@ function listener(event, exec_state, event_data, data) {
       assertTrue(expected_events >= 0);
       assertEquals("uncaught", event_data.exception().message);
       assertTrue(event_data.promise() instanceof Promise);
-      assertEquals(q, event_data.promise());
+      assertSame(q, event_data.promise());
       assertTrue(event_data.uncaught());
       // Assert that the debug event is triggered at the throw site.
assertTrue(exec_state.frame(0).sourceLineText().indexOf("// event") 
0);

Index: test/mjsunit/es6/debug-promises/throw-with-throw-in-reject.js
diff --git a/test/mjsunit/es6/debug-promises/throw-with-throw-in-reject.js b/test/mjsunit/es6/debug-promises/throw-with-throw-in-reject.js index b57afd42f6863a7f1a9d576e2b92f060cbe3181f..1ea1c7f9ff3eedb0318e9975c86b369ed734fd03 100644 
--- a/test/mjsunit/es6/debug-promises/throw-with-throw-in-reject.js
+++ b/test/mjsunit/es6/debug-promises/throw-with-throw-in-reject.js
@@ -53,7 +53,7 @@ function listener(event, exec_state, event_data, data) {
       } else {
         assertUnreachable();
       }
-      assertEquals(q, event_data.promise());
+      assertSame(q, event_data.promise());
assertTrue(exec_state.frame(0).sourceLineText().indexOf('// event') 
0);

     }
   } catch (e) {
Index: test/mjsunit/es6/debug-promises/throw-with-undefined-reject.js
diff --git a/test/mjsunit/es6/debug-promises/throw-with-undefined-reject.js b/test/mjsunit/es6/debug-promises/throw-with-undefined-reject.js index 0162fe1006e55db7755abaffb9109927f4768505..94dcdffa225e11a5255801e8d9eccfdd972e50f7 100644 
--- a/test/mjsunit/es6/debug-promises/throw-with-undefined-reject.js
+++ b/test/mjsunit/es6/debug-promises/throw-with-undefined-reject.js
@@ -53,7 +53,7 @@ function listener(event, exec_state, event_data, data) {
       } else {
         assertUnreachable();
       }
-      assertEquals(q, event_data.promise());
+      assertSame(q, event_data.promise());
     }
   } catch (e) {
     %AbortJS(e + "\n" + e.stack);


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group. 
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to