On 2014/08/08 at 13:40:17, rossberg wrote:
On 2014/08/08 11:24:05, rossberg wrote:
> LGTM, modulo one additional test.
>
>
https://codereview.chromium.org/448013005/diff/1/test/mjsunit/es6/collections.js
> File test/mjsunit/es6/collections.js (right):
>
>
https://codereview.chromium.org/448013005/diff/1/test/mjsunit/es6/collections.js#newcode1026
> test/mjsunit/es6/collections.js:1026: // @@iterator result not object
> Exclusively for weak maps and sets, we should also have a test where the
> iterator returns some r where r.value is not an object (i.e., not a
legal
key
> for weak collections).
I landed it anyway, to sneak it into M38. But I'd appreciate if you could
add
these tiny tests in a follow-up CL.
Thanks. Follow up CL with tests: https://codereview.chromium.org/451033003
https://codereview.chromium.org/448013005/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
