Some drive-by nits:
https://codereview.chromium.org/418143007/diff/120001/test/cctest/test-parsing.cc
File test/cctest/test-parsing.cc (right):
https://codereview.chromium.org/418143007/diff/120001/test/cctest/test-parsing.cc#newcode3353
test/cctest/test-parsing.cc:3353: // Tests that parser and preparser
accept valid arrow functions syntax.
Nit: this comment is out of date.
https://codereview.chromium.org/418143007/diff/120001/test/cctest/test-parsing.cc#newcode3354
test/cctest/test-parsing.cc:3354: const char* context_data[][2] = {{"",
";"},
You can probably get rid of some of the contexts or add more relevant
ones. These were mostly interesting for arrow functions.
https://codereview.chromium.org/418143007/diff/120001/test/cctest/test-parsing.cc#newcode3377
test/cctest/test-parsing.cc:3377: // Tests that parser and preparser
accept valid arrow functions syntax.
Same here.
https://codereview.chromium.org/418143007/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
