Revision: 23066
Author:   [email protected]
Date:     Tue Aug 12 08:06:02 2014 UTC
Log: Disable code generation in tests that use GraphBuilderTester on platforms that have no TF backend.

[email protected]
BUG=

Review URL: https://codereview.chromium.org/457343003
http://code.google.com/p/v8/source/detail?r=23066

Modified:
 /branches/bleeding_edge/test/cctest/compiler/graph-builder-tester.cc
 /branches/bleeding_edge/test/cctest/compiler/test-simplified-lowering.cc

=======================================
--- /branches/bleeding_edge/test/cctest/compiler/graph-builder-tester.cc Mon Aug 11 15:55:28 2014 UTC +++ /branches/bleeding_edge/test/cctest/compiler/graph-builder-tester.cc Tue Aug 12 08:06:02 2014 UTC
@@ -31,6 +31,7 @@

 byte* MachineCallHelper::Generate() {
   DCHECK(parameter_count() == 0 || parameters_ != NULL);
+  if (!Pipeline::SupportedBackend()) return NULL;
   if (code_.is_null()) {
     Zone* zone = graph_->zone();
     CompilationInfo info(zone->isolate(), zone);
=======================================
--- /branches/bleeding_edge/test/cctest/compiler/test-simplified-lowering.cc Mon Aug 11 18:54:40 2014 UTC +++ /branches/bleeding_edge/test/cctest/compiler/test-simplified-lowering.cc Tue Aug 12 08:06:02 2014 UTC
@@ -114,9 +114,9 @@
   t.Return(load);

   t.LowerAllNodes();
+  t.GenerateCode();

   if (Pipeline::SupportedTarget()) {
-    t.GenerateCode();
     Handle<JSObject> src = TestObject();
     Handle<Map> src_map(src->map());
     Object* result = t.Call(*src);  // TODO(titzer): raw pointers in call
@@ -132,9 +132,9 @@
   t.Return(t.jsgraph.TrueConstant());

   t.LowerAllNodes();
+  t.GenerateCode();

   if (Pipeline::SupportedTarget()) {
-    t.GenerateCode();
     Handle<JSObject> src = TestObject();
     Handle<Map> src_map(src->map());
     Handle<JSObject> dst = TestObject();
@@ -152,9 +152,9 @@
   t.Return(load);

   t.LowerAllNodes();
+  t.GenerateCode();

   if (Pipeline::SupportedTarget()) {
-    t.GenerateCode();
     Handle<JSObject> src = TestObject();
     Handle<FixedArray> src_props(src->properties());
     Object* result = t.Call(*src);  // TODO(titzer): raw pointers in call
@@ -171,9 +171,9 @@
   t.Return(load);

   t.LowerAllNodes();
+  t.GenerateCode();

   if (Pipeline::SupportedTarget()) {
-    t.GenerateCode();
     Handle<JSObject> src = TestObject();
     Handle<Map> src_map(src->map());
     Handle<JSObject> dst = TestObject();
@@ -194,9 +194,9 @@
   t.Return(load);

   t.LowerAllNodes();
+  t.GenerateCode();

   if (Pipeline::SupportedTarget()) {
-    t.GenerateCode();
     Handle<FixedArray> array = t.factory()->NewFixedArray(2);
     Handle<JSObject> src = TestObject();
     Handle<JSObject> dst = TestObject();
@@ -223,9 +223,9 @@
   t.Return(t.jsgraph.TrueConstant());

   t.LowerAllNodes();
+  t.GenerateCode();

   if (Pipeline::SupportedTarget()) {
-    t.GenerateCode();
     Handle<JSArrayBuffer> array = t.factory()->NewJSArrayBuffer();
     const int array_length = 2 * index;
Runtime::SetupArrayBufferAllocatingData(t.isolate(), array, array_length);
@@ -407,9 +407,9 @@
     t.StoreElement(access, ptr, t.Int32Constant(to_index), load);
     t.Return(t.jsgraph.TrueConstant());
     t.LowerAllNodes();
+    t.GenerateCode();

     if (Pipeline::SupportedTarget()) {
-      t.GenerateCode();
       Object* result = t.Call();
       CHECK_EQ(t.isolate()->heap()->true_value(), result);
     }
@@ -429,9 +429,9 @@
     t.StoreField(to_access, ptr, load);
     t.Return(t.jsgraph.TrueConstant());
     t.LowerAllNodes();
+    t.GenerateCode();

     if (Pipeline::SupportedTarget()) {
-      t.GenerateCode();
       Object* result = t.Call();
       CHECK_EQ(t.isolate()->heap()->true_value(), result);
     }
@@ -468,9 +468,9 @@
     index = t.environment()->Pop();
     t.Return(t.jsgraph.TrueConstant());
     t.LowerAllNodes();
+    t.GenerateCode();

     if (Pipeline::SupportedTarget()) {
-      t.GenerateCode();
       Object* result = t.Call();
       CHECK_EQ(t.isolate()->heap()->true_value(), result);
     }

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to