Reviewers: Michael Starzinger,
Description:
Enable more tests for simplified lowering after assuming signed for word32.
[email protected]
BUG=
Please review this at https://codereview.chromium.org/461933002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+4, -7 lines):
M test/cctest/compiler/test-simplified-lowering.cc
Index: test/cctest/compiler/test-simplified-lowering.cc
diff --git a/test/cctest/compiler/test-simplified-lowering.cc
b/test/cctest/compiler/test-simplified-lowering.cc
index
1fcef85a91c92753c7aef292de8b039556e942e8..0416121a1f50587ff820c13f1d2e1a60071584a6
100644
--- a/test/cctest/compiler/test-simplified-lowering.cc
+++ b/test/cctest/compiler/test-simplified-lowering.cc
@@ -1006,13 +1006,10 @@ void CheckChangeInsertion(IrOpcode::Value expected,
RepType from, RepType to) {
TEST(InsertBasicChanges) {
- if (false) {
- // TODO(titzer): these changes need the output to have the right type.
- CheckChangeInsertion(IrOpcode::kChangeFloat64ToInt32, rFloat64,
tInt32);
- CheckChangeInsertion(IrOpcode::kChangeFloat64ToUint32, rFloat64,
tUint32);
- CheckChangeInsertion(IrOpcode::kChangeTaggedToInt32, rTagged, tInt32);
- CheckChangeInsertion(IrOpcode::kChangeTaggedToUint32, rTagged,
tUint32);
- }
+ CheckChangeInsertion(IrOpcode::kChangeFloat64ToInt32, rFloat64, tInt32);
+ CheckChangeInsertion(IrOpcode::kChangeFloat64ToUint32, rFloat64,
tUint32);
+ CheckChangeInsertion(IrOpcode::kChangeTaggedToInt32, rTagged, tInt32);
+ CheckChangeInsertion(IrOpcode::kChangeTaggedToUint32, rTagged, tUint32);
CheckChangeInsertion(IrOpcode::kChangeFloat64ToTagged, rFloat64,
rTagged);
CheckChangeInsertion(IrOpcode::kChangeTaggedToFloat64, rTagged,
rFloat64);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
