Reviewers: jarin,

Message:
PTAL

Description:
Rename COMPILER_TEST to TARGET_TARGET.

The name COMPILER_TEST is misleading here.

Please review this at https://codereview.chromium.org/465913002/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+9, -9 lines):
  M test/compiler-unittests/arm/instruction-selector-arm-unittest.cc
  M test/compiler-unittests/compiler-unittests.h
  M test/compiler-unittests/instruction-selector-unittest.cc


Index: test/compiler-unittests/arm/instruction-selector-arm-unittest.cc
diff --git a/test/compiler-unittests/arm/instruction-selector-arm-unittest.cc b/test/compiler-unittests/arm/instruction-selector-arm-unittest.cc index 3e51722ed36e6b2f22714cd3d8b4a83e3fb45a21..b781ac8f9f5c6adf59f4bfc868c248f5f0107972 100644
--- a/test/compiler-unittests/arm/instruction-selector-arm-unittest.cc
+++ b/test/compiler-unittests/arm/instruction-selector-arm-unittest.cc
@@ -11,7 +11,7 @@ namespace compiler {
 class InstructionSelectorARMTest : public InstructionSelectorTest {};


-COMPILER_TEST_F(InstructionSelectorARMTest, Int32AddP) {
+TARGET_TEST_F(InstructionSelectorARMTest, Int32AddP) {
   StreamBuilder m(this, kMachineWord32, kMachineWord32, kMachineWord32);
   m.Return(m.Int32Add(m.Parameter(0), m.Parameter(1)));
   Stream s = m.Build();
Index: test/compiler-unittests/compiler-unittests.h
diff --git a/test/compiler-unittests/compiler-unittests.h b/test/compiler-unittests/compiler-unittests.h index 6d063ee27be22c45afb46d9f7d25967866a5e4bc..aa978a2c52221ef3bb48be5b4f1c11a57f190c64 100644
--- a/test/compiler-unittests/compiler-unittests.h
+++ b/test/compiler-unittests/compiler-unittests.h
@@ -13,23 +13,23 @@ namespace v8 {
 namespace internal {
 namespace compiler {

-// The COMPILER_TEST(Case, Name) macro works just like
+// The TARGET_TEST(Case, Name) macro works just like
 // TEST(Case, Name), except that the test is disabled
 // if the platform is not a supported TurboFan target.
 #if V8_TURBOFAN_TARGET
-#define COMPILER_TEST(Case, Name) TEST(Case, Name)
+#define TARGET_TEST(Case, Name) TEST(Case, Name)
 #else
-#define COMPILER_TEST(Case, Name) TEST(Case, DISABLED_##Name)
+#define TARGET_TEST(Case, Name) TEST(Case, DISABLED_##Name)
 #endif


-// The COMPILER_TEST_F(Case, Name) macro works just like
+// The TARGET_TEST_F(Case, Name) macro works just like
 // TEST_F(Case, Name), except that the test is disabled
 // if the platform is not a supported TurboFan target.
 #if V8_TURBOFAN_TARGET
-#define COMPILER_TEST_F(Case, Name) TEST_F(Case, Name)
+#define TARGET_TEST_F(Case, Name) TEST_F(Case, Name)
 #else
-#define COMPILER_TEST_F(Case, Name) TEST_F(Case, DISABLED_##Name)
+#define TARGET_TEST_F(Case, Name) TEST_F(Case, DISABLED_##Name)
 #endif


Index: test/compiler-unittests/instruction-selector-unittest.cc
diff --git a/test/compiler-unittests/instruction-selector-unittest.cc b/test/compiler-unittests/instruction-selector-unittest.cc index a862f98f1087f6c93226b362c47847fe46d3decb..70186529afbee0e083190c965dc2a1e7d098f351 100644
--- a/test/compiler-unittests/instruction-selector-unittest.cc
+++ b/test/compiler-unittests/instruction-selector-unittest.cc
@@ -62,7 +62,7 @@ InstructionSelectorTest::Stream InstructionSelectorTest::StreamBuilder::Build(
 }


-COMPILER_TEST_F(InstructionSelectorTest, ReturnP) {
+TARGET_TEST_F(InstructionSelectorTest, ReturnP) {
   StreamBuilder m(this, kMachineWord32, kMachineWord32);
   m.Return(m.Parameter(0));
   Stream s = m.Build(kAllInstructions);
@@ -74,7 +74,7 @@ COMPILER_TEST_F(InstructionSelectorTest, ReturnP) {
 }


-COMPILER_TEST_F(InstructionSelectorTest, ReturnImm) {
+TARGET_TEST_F(InstructionSelectorTest, ReturnImm) {
   StreamBuilder m(this, kMachineWord32);
   m.Return(m.Int32Constant(0));
   Stream s = m.Build(kAllInstructions);


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to