https://codereview.chromium.org/460723002/diff/1/src/compiler/pipeline.cc
File src/compiler/pipeline.cc (right):
https://codereview.chromium.org/460723002/diff/1/src/compiler/pipeline.cc#newcode77
src/compiler/pipeline.cc:77: Vector<char> str = Vector<char>::New(256);
On 2014/08/11 18:31:23, Michael Starzinger wrote:
nit: s/str/filename/
Done.
https://codereview.chromium.org/460723002/diff/1/src/compiler/pipeline.cc#newcode81
src/compiler/pipeline.cc:81: SNPrintF(str, "%s-%s.dot", name.get(),
phase);
On 2014/08/11 18:31:23, Michael Starzinger wrote:
Can we get a common prefix for all of the files? That way they are
nicely
grouped in any file browser and can also be easily added to the GIT
ignore file.
I vote for "turbo-%s-%s.dot" as a file name.
Done.
https://codereview.chromium.org/460723002/diff/1/src/compiler/pipeline.cc#newcode86
src/compiler/pipeline.cc:86: FILE* file = fopen(str.start(), "w+");
On 2014/08/11 18:31:23, Michael Starzinger wrote:
I think we will need to use base::OS::FOpen to make all platforms
happy here.
Done.
https://codereview.chromium.org/460723002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
