[v8-dev] Tests for ChangeLowering are target tests since they use the Linkage. (issue 463803003 by [email protected])

Tue, 12 Aug 2014 02:53:09 -0700 

Reviewers: titzer,

Message:
Committed patchset #1 manually as 23071 (tree was closed).

Description:
Tests for ChangeLowering are target tests since they use the Linkage.

This fixes MIPS.

[email protected]

Committed: https://code.google.com/p/v8/source/detail?r=23071

Please review this at https://codereview.chromium.org/463803003/

SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge

Affected files (+18, -8 lines):
  M test/compiler-unittests/change-lowering-unittest.cc
  M test/compiler-unittests/compiler-unittests.h


Index: test/compiler-unittests/change-lowering-unittest.cc
diff --git a/test/compiler-unittests/change-lowering-unittest.cc b/test/compiler-unittests/change-lowering-unittest.cc index 70d681db5cae3c4cef403d17526be272157a58d1..68de48013c067fd2ba63ad42196ecb0c8a9168c9 100644 
--- a/test/compiler-unittests/change-lowering-unittest.cc
+++ b/test/compiler-unittests/change-lowering-unittest.cc
@@ -66,7 +66,7 @@ typedef ::testing::Types<int32_t, int64_t> ChangeLoweringTypes; 
 TYPED_TEST_CASE(ChangeLoweringTest, ChangeLoweringTypes);


-TYPED_TEST(ChangeLoweringTest, ChangeBitToBool) {
+TARGET_TYPED_TEST(ChangeLoweringTest, ChangeBitToBool) {
   Node* val = this->Parameter(0);
   Node* node =
       this->graph()->NewNode(this->simplified()->ChangeBitToBool(), val);
@@ -92,7 +92,7 @@ TYPED_TEST(ChangeLoweringTest, ChangeBitToBool) {
 }


-TYPED_TEST(ChangeLoweringTest, StringAdd) {
+TARGET_TYPED_TEST(ChangeLoweringTest, StringAdd) {
   Node* node = this->graph()->NewNode(this->simplified()->StringAdd(),
this->Parameter(0), this->Parameter(1)); 
   Reduction reduction = this->Reduce(node);
@@ -106,7 +106,7 @@ class ChangeLowering32Test : public ChangeLoweringTest<int32_t> { 
 };


-TEST_F(ChangeLowering32Test, ChangeBoolToBit) {
+TARGET_TEST_F(ChangeLowering32Test, ChangeBoolToBit) {
   Node* val = Parameter(0);
   Node* node = graph()->NewNode(simplified()->ChangeBoolToBit(), val);
   Reduction reduction = Reduce(node);
@@ -117,7 +117,7 @@ TEST_F(ChangeLowering32Test, ChangeBoolToBit) {
 }


-TEST_F(ChangeLowering32Test, ChangeInt32ToTagged) {
+TARGET_TEST_F(ChangeLowering32Test, ChangeInt32ToTagged) {
   Node* val = Parameter(0);
   Node* node = graph()->NewNode(simplified()->ChangeInt32ToTagged(), val);
   Reduction reduction = Reduce(node);
@@ -155,7 +155,7 @@ TEST_F(ChangeLowering32Test, ChangeInt32ToTagged) {
 }


-TEST_F(ChangeLowering32Test, ChangeTaggedToFloat64) {
+TARGET_TEST_F(ChangeLowering32Test, ChangeTaggedToFloat64) {
   Node* val = Parameter(0);
Node* node = graph()->NewNode(simplified()->ChangeTaggedToFloat64(), val); 
   Reduction reduction = Reduce(node);
@@ -195,7 +195,7 @@ class ChangeLowering64Test : public ChangeLoweringTest<int64_t> { 
 };


-TEST_F(ChangeLowering64Test, ChangeBoolToBit) {
+TARGET_TEST_F(ChangeLowering64Test, ChangeBoolToBit) {
   Node* val = Parameter(0);
   Node* node = graph()->NewNode(simplified()->ChangeBoolToBit(), val);
   Reduction reduction = Reduce(node);
@@ -206,7 +206,7 @@ TEST_F(ChangeLowering64Test, ChangeBoolToBit) {
 }


-TEST_F(ChangeLowering64Test, ChangeInt32ToTagged) {
+TARGET_TEST_F(ChangeLowering64Test, ChangeInt32ToTagged) {
   Node* val = Parameter(0);
   Node* node = graph()->NewNode(simplified()->ChangeInt32ToTagged(), val);
   Reduction reduction = Reduce(node);
@@ -219,7 +219,7 @@ TEST_F(ChangeLowering64Test, ChangeInt32ToTagged) {
 }


-TEST_F(ChangeLowering64Test, ChangeTaggedToFloat64) {
+TARGET_TEST_F(ChangeLowering64Test, ChangeTaggedToFloat64) {
   Node* val = Parameter(0);
Node* node = graph()->NewNode(simplified()->ChangeTaggedToFloat64(), val); 
   Reduction reduction = Reduce(node);
Index: test/compiler-unittests/compiler-unittests.h
diff --git a/test/compiler-unittests/compiler-unittests.h b/test/compiler-unittests/compiler-unittests.h index aa978a2c52221ef3bb48be5b4f1c11a57f190c64..091b137066d07b37ef3a11235cbaf6bec18349f3 100644 
--- a/test/compiler-unittests/compiler-unittests.h
+++ b/test/compiler-unittests/compiler-unittests.h
@@ -33,6 +33,16 @@ namespace compiler {
 #endif


+// The TARGET_TYPED_TEST(Case, Name) macro works just like
+// TYPED_TEST(Case, Name), except that the test is disabled
+// if the platform is not a supported TurboFan target.
+#if V8_TURBOFAN_TARGET
+#define TARGET_TYPED_TEST(Case, Name) TYPED_TEST(Case, Name)
+#else
+#define TARGET_TYPED_TEST(Case, Name) TYPED_TEST(Case, DISABLED_##Name)
+#endif
+
+
 class CompilerTest : public ::testing::Test {
  public:
   CompilerTest();


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group. 
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to