Reviewers: Hannes Payer,
Description:
Fix predictable mode to make time pass faster.
[email protected]
Please review this at https://codereview.chromium.org/460413002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -7 lines):
M src/d8.cc
M src/heap/heap.h
M test/benchmarks/benchmarks.status
M test/benchmarks/testcfg.py
Index: src/d8.cc
diff --git a/src/d8.cc b/src/d8.cc
index
356a64b2dcae1820339b7309c4e395a9d91b323e..d0dfbbb364b3a2faa7a12e620dc0c3e215eec6d0
100644
--- a/src/d8.cc
+++ b/src/d8.cc
@@ -332,7 +332,6 @@ void Shell::PerformanceNow(const
v8::FunctionCallbackInfo<v8::Value>& args) {
Isolate* v8_isolate = args.GetIsolate();
i::Heap* heap = reinterpret_cast<i::Isolate*>(v8_isolate)->heap();
args.GetReturnValue().Set(heap->synthetic_time());
-
} else {
base::TimeDelta delta =
base::TimeTicks::HighResolutionNow() - kInitialTicks;
Index: src/heap/heap.h
diff --git a/src/heap/heap.h b/src/heap/heap.h
index
c313333362ff7acfa2b3ff6ef519d800276dbeed..b10a47665cf96ae35dc6f8bc3d3d67f7dd7ea352
100644
--- a/src/heap/heap.h
+++ b/src/heap/heap.h
@@ -960,7 +960,7 @@ class Heap {
// Returns deterministic "time" value in ms. Works only with
// FLAG_verify_predictable.
- double synthetic_time() { return allocations_count_ / 100.0; }
+ double synthetic_time() { return allocations_count_ / 2.0; }
// Print short heap statistics.
void PrintShortHeapStatistics();
Index: test/benchmarks/benchmarks.status
diff --git a/test/benchmarks/benchmarks.status
b/test/benchmarks/benchmarks.status
index
1afd5eca2473f05996ad8de684bab5081287da41..3bdacc2a9f2cd9b104909d59f6c466b2a44608dc
100644
--- a/test/benchmarks/benchmarks.status
+++ b/test/benchmarks/benchmarks.status
@@ -29,7 +29,5 @@
[ALWAYS, {
# Too slow in Debug mode.
'octane/mandreel': [PASS, ['mode == debug', SKIP]],
- # TODO(mstarzinger,ishell): Timeout with TF in predictable mode.
- 'octane/richards': [PASS, NO_VARIANTS],
}], # ALWAYS
]
Index: test/benchmarks/testcfg.py
diff --git a/test/benchmarks/testcfg.py b/test/benchmarks/testcfg.py
index
8c573ba30b11cc53c4f03e2d74fd65e79fbd01ae..6607bef8cc68bc51c80e088a40bd32d069a2da4d
100644
--- a/test/benchmarks/testcfg.py
+++ b/test/benchmarks/testcfg.py
@@ -31,7 +31,6 @@ import shutil
import subprocess
import tarfile
-from testrunner.local import statusfile
from testrunner.local import testsuite
from testrunner.objects import testcase
@@ -184,8 +183,6 @@ class BenchmarksTestSuite(testsuite.TestSuite):
os.chdir(old_cwd)
def VariantFlags(self, testcase, default_flags):
- if testcase.outcomes and
statusfile.OnlyStandardVariant(testcase.outcomes):
- return [[]]
# Both --nocrankshaft and --stressopt are very slow. Add TF but without
# always opt to match the way the benchmarks are run for performance
# testing.
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
