Reviewers: Sven Panne, Michael Achenbach (OOO),
Message:
hello,
Sven & Michael.
I found that the range-based for loops is supported
since GCC 4.6. The compilation will fail if GCC < 4.6.
So I add this condition.
please review it.
thanks.
Description:
Add the condition for enabling c++11 test.
The range-based for loops is supported since GCC 4.6.
BUG=
Please review this at https://codereview.chromium.org/468023002/
SVN Base: https://chromium.googlesource.com/external/v8.git@bleeding_edge
Affected files (+2, -1 lines):
M test/cctest/test-utils.cc
Index: test/cctest/test-utils.cc
diff --git a/test/cctest/test-utils.cc b/test/cctest/test-utils.cc
index
cf539305b3074985c0c1216f0353e0339ba5aa8a..16d8469f4b47c56887711c235ae19d9129c59bae
100644
--- a/test/cctest/test-utils.cc
+++ b/test/cctest/test-utils.cc
@@ -223,7 +223,8 @@ TEST(SequenceCollectorRegression) {
// TODO(svenpanne) Unconditionally test this when our infrastructure is
fixed.
-#if !V8_CC_MSVC && !V8_OS_NACL
+// Range-based for loops is supported since GCC 4.6
+#if !V8_CC_MSVC && !V8_OS_NACL && V8_GNUC_PREREQ(4, 6, 0)
TEST(CPlusPlus11Features) {
struct S {
bool x;
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.