On 2014/08/12 21:17:41, Michael Starzinger wrote:
LGTM. Yes, this corresponds to what we discussed very well. :)
https://codereview.chromium.org/464033002/diff/1/src/compiler/ast-graph-builder.h
File src/compiler/ast-graph-builder.h (right):
https://codereview.chromium.org/464033002/diff/1/src/compiler/ast-graph-builder.h#newcode174
src/compiler/ast-graph-builder.h:174: enum OutputFrameStateCombine {
PUSH_OUTPUT, IGNORE_OUTPUT };
nit: Can we add a comment describing the semantics behind this enum?
https://codereview.chromium.org/464033002/diff/1/src/compiler/ast-graph-builder.h#newcode176
src/compiler/ast-graph-builder.h:176: void BuildLazyBailout(Node* node,
BailoutId ast_id,
nit: Since the BuildFoo methods all have a clear semantic (see comment
above
in
line 69), how would you feel about naming this AttachLazyBailout or
PrepareLazyBailout instead?
https://codereview.chromium.org/464033002/diff/1/src/compiler/ast-graph-builder.h#newcode178
src/compiler/ast-graph-builder.h:178: OutputFrameStateCombine
StateCombineFromAstContext();
suggestion: I would be fine with moving this into AstContext so that one
could
call "ast_context()->GetStateCombine()" instead (if that still makes all
of
them
fit into one line ^^).
All this should be addressed now. Thanks!
https://codereview.chromium.org/464033002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
