On 2014/08/13 09:45:02, Benedikt Meurer wrote:
https://codereview.chromium.org/470533002/diff/1/test/cctest/compiler/value-helper.h
File test/cctest/compiler/value-helper.h (right):
https://codereview.chromium.org/470533002/diff/1/test/cctest/compiler/value-helper.h#newcode127
test/cctest/compiler/value-helper.h:127: #define FOR_INT32_SHIFTS(var) for
(int32_t var = 0; var < 32; var++)
We don't need that, shift amount is always/automatically unsigned in C++.
In an upcoming CL I am distinguishing more carefully between signed and
unsigned
integers and also unifying MachineType and RepType. Having both
FOR_INT32_SHIFTS
and FOR_UINT32_SHIFTS is a simpler change now and I think will make that CL
easier when I rebase it.
https://codereview.chromium.org/470533002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
