LGTM with comments.
https://codereview.chromium.org/468073002/diff/1/src/objects.cc
File src/objects.cc (right):
https://codereview.chromium.org/468073002/diff/1/src/objects.cc#newcode4858
src/objects.cc:4858: Handle<Object>
JSObject::DeletePropertyPostInterceptor(Handle<JSObject> object,
This seems to have become dead code now.
https://codereview.chromium.org/468073002/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/468073002/diff/1/src/objects.h#newcode2710
src/objects.h:2710: Handle<JSObject> object, Handle<JSObject> receiver,
Handle<Name> name);
nit: please use matching names in declaration and definition, i.e.
s/object/holder/
https://codereview.chromium.org/468073002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
