Reviewers: sigurds,
Description:
Simplify public pipeline interface.
[email protected]
Please review this at https://codereview.chromium.org/471563002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+13, -13 lines):
M src/compiler/pipeline.h
M src/compiler/pipeline.cc
Index: src/compiler/pipeline.cc
diff --git a/src/compiler/pipeline.cc b/src/compiler/pipeline.cc
index
b0b3eb76efe8453be05d59a018a7ebe88439b504..da25a91f2c9e6286ee4ba0efbaeafc71b0e52bbd
100644
--- a/src/compiler/pipeline.cc
+++ b/src/compiler/pipeline.cc
@@ -73,6 +73,15 @@ class PhaseStats {
};
+static inline bool VerifyGraphs() {
+#ifdef DEBUG
+ return true;
+#else
+ return FLAG_turbo_verify;
+#endif
+}
+
+
void Pipeline::VerifyAndPrintGraph(Graph* graph, const char* phase) {
if (FLAG_trace_turbo) {
char buffer[256];
Index: src/compiler/pipeline.h
diff --git a/src/compiler/pipeline.h b/src/compiler/pipeline.h
index
4c1c0bcea9a20a278948484b63a007eb9a56e80f..9f8241a63c4ee4984f2f261f333a6447ce849c09
100644
--- a/src/compiler/pipeline.h
+++ b/src/compiler/pipeline.h
@@ -17,7 +17,6 @@ namespace internal {
namespace compiler {
// Clients of this interface shouldn't depend on lots of compiler
internals.
-class CallDescriptor;
class Graph;
class Schedule;
class SourcePositionTable;
@@ -35,27 +34,19 @@ class Pipeline {
Handle<Code> GenerateCodeForMachineGraph(Linkage* linkage, Graph* graph,
Schedule* schedule = NULL);
- CompilationInfo* info() const { return info_; }
- Zone* zone() { return info_->zone(); }
- Isolate* isolate() { return info_->isolate(); }
-
static inline bool SupportedBackend() { return V8_TURBOFAN_BACKEND != 0;
}
static inline bool SupportedTarget() { return V8_TURBOFAN_TARGET != 0; }
- static inline bool VerifyGraphs() {
-#ifdef DEBUG
- return true;
-#else
- return FLAG_turbo_verify;
-#endif
- }
-
static void SetUp();
static void TearDown();
private:
CompilationInfo* info_;
+ CompilationInfo* info() const { return info_; }
+ Isolate* isolate() { return info_->isolate(); }
+ Zone* zone() { return info_->zone(); }
+
Schedule* ComputeSchedule(Graph* graph);
void VerifyAndPrintGraph(Graph* graph, const char* phase);
Handle<Code> GenerateCode(Linkage* linkage, Graph* graph, Schedule*
schedule,
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
