Revision: 23106
Author:   [email protected]
Date:     Wed Aug 13 14:05:37 2014 UTC
Log:      Simplify public pipeline interface.

[email protected]

Review URL: https://codereview.chromium.org/471563002
http://code.google.com/p/v8/source/detail?r=23106

Modified:
 /branches/bleeding_edge/src/compiler/pipeline.cc
 /branches/bleeding_edge/src/compiler/pipeline.h

=======================================
--- /branches/bleeding_edge/src/compiler/pipeline.cc Tue Aug 12 13:09:09 2014 UTC +++ /branches/bleeding_edge/src/compiler/pipeline.cc Wed Aug 13 14:05:37 2014 UTC
@@ -73,6 +73,15 @@
 };


+static inline bool VerifyGraphs() {
+#ifdef DEBUG
+  return true;
+#else
+  return FLAG_turbo_verify;
+#endif
+}
+
+
 void Pipeline::VerifyAndPrintGraph(Graph* graph, const char* phase) {
   if (FLAG_trace_turbo) {
     char buffer[256];
=======================================
--- /branches/bleeding_edge/src/compiler/pipeline.h Tue Aug 5 13:20:26 2014 UTC +++ /branches/bleeding_edge/src/compiler/pipeline.h Wed Aug 13 14:05:37 2014 UTC
@@ -17,7 +17,6 @@
 namespace compiler {

// Clients of this interface shouldn't depend on lots of compiler internals.
-class CallDescriptor;
 class Graph;
 class Schedule;
 class SourcePositionTable;
@@ -34,27 +33,19 @@
   // is {NULL}, then compute a new schedule for code generation.
   Handle<Code> GenerateCodeForMachineGraph(Linkage* linkage, Graph* graph,
                                            Schedule* schedule = NULL);
-
-  CompilationInfo* info() const { return info_; }
-  Zone* zone() { return info_->zone(); }
-  Isolate* isolate() { return info_->isolate(); }

static inline bool SupportedBackend() { return V8_TURBOFAN_BACKEND != 0; }
   static inline bool SupportedTarget() { return V8_TURBOFAN_TARGET != 0; }
-
-  static inline bool VerifyGraphs() {
-#ifdef DEBUG
-    return true;
-#else
-    return FLAG_turbo_verify;
-#endif
-  }

   static void SetUp();
   static void TearDown();

  private:
   CompilationInfo* info_;
+
+  CompilationInfo* info() const { return info_; }
+  Isolate* isolate() { return info_->isolate(); }
+  Zone* zone() { return info_->zone(); }

   Schedule* ComputeSchedule(Graph* graph);
   void VerifyAndPrintGraph(Graph* graph, const char* phase);

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to