Reviewers: titzer,
Description:
Remove obsolete workaround from FunctionTester.
[email protected]
Please review this at https://codereview.chromium.org/471593002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+0, -10 lines):
M src/compiler/js-generic-lowering.cc
M test/cctest/compiler/function-tester.h
Index: src/compiler/js-generic-lowering.cc
diff --git a/src/compiler/js-generic-lowering.cc
b/src/compiler/js-generic-lowering.cc
index
68cc1cea9053358bbd5a065647e8300b83bdc56e..08cb89ada18888ef389172b62e46f19f4973c5b8
100644
--- a/src/compiler/js-generic-lowering.cc
+++ b/src/compiler/js-generic-lowering.cc
@@ -474,8 +474,6 @@ Node* JSGenericLowering::LowerJSInstanceOf(Node* node) {
Node* JSGenericLowering::LowerJSLoadContext(Node* node) {
ContextAccess access = OpParameter<ContextAccess>(node);
- // TODO(mstarzinger): Use simplified operators instead of machine
operators
- // here so that load/store optimization can be applied afterwards.
for (int i = 0; i < access.depth(); ++i) {
node->ReplaceInput(
0, graph()->NewNode(
@@ -492,8 +490,6 @@ Node* JSGenericLowering::LowerJSLoadContext(Node* node)
{
Node* JSGenericLowering::LowerJSStoreContext(Node* node) {
ContextAccess access = OpParameter<ContextAccess>(node);
- // TODO(mstarzinger): Use simplified operators instead of machine
operators
- // here so that load/store optimization can be applied afterwards.
for (int i = 0; i < access.depth(); ++i) {
node->ReplaceInput(
0, graph()->NewNode(
Index: test/cctest/compiler/function-tester.h
diff --git a/test/cctest/compiler/function-tester.h
b/test/cctest/compiler/function-tester.h
index
2ed2fe99883da65ae29d0c40ef287d40b1b41ed0..0b1ba5ce2c3150472cd040828d72863223317063
100644
--- a/test/cctest/compiler/function-tester.h
+++ b/test/cctest/compiler/function-tester.h
@@ -98,8 +98,6 @@ class FunctionTester : public InitializedHandleScope {
CHECK(isolate->has_pending_exception());
CHECK(try_catch.HasCaught());
CHECK(no_result.is_null());
- // TODO(mstarzinger): Temporary workaround for issue chromium:362388.
- isolate->OptionalRescheduleException(true);
}
v8::Handle<v8::Message> CheckThrowsReturnMessage(Handle<Object> a,
@@ -109,10 +107,6 @@ class FunctionTester : public InitializedHandleScope {
CHECK(isolate->has_pending_exception());
CHECK(try_catch.HasCaught());
CHECK(no_result.is_null());
- // TODO(mstarzinger): Calling OptionalRescheduleException is a dirty
hack,
- // it's the only way to make Message() not to assert because an
external
- // exception has been caught by the try_catch.
- isolate->OptionalRescheduleException(true);
return try_catch.Message();
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
