LGTM
Just a few nits.
https://codereview.chromium.org/465353002/diff/1/test/mjsunit/es6/math-expm1.js
File test/mjsunit/es6/math-expm1.js (right):
https://codereview.chromium.org/465353002/diff/1/test/mjsunit/es6/math-expm1.js#newcode24
test/mjsunit/es6/math-expm1.js:24: }
For an additional sanity check, why not use the mathematical property
that expm1(n*log(2)) = exp(n*log(2)) - 1 = 2^n - 1? For simplicity, just
use integer n. For bonus points allow n = m/2 for integer m. This only
requires computing sqrt(2). Or perhaps Math.pow is accurate to < 1 ulp?
The above sanity check would fail if exp(x) is wrong, and we know that
exp(x) is (now) less accurate than expm1.
https://codereview.chromium.org/465353002/diff/1/third_party/fdlibm/fdlibm.js
File third_party/fdlibm/fdlibm.js (right):
https://codereview.chromium.org/465353002/diff/1/third_party/fdlibm/fdlibm.js#newcode429
third_party/fdlibm/fdlibm.js:429: macro KLOG1P(x)
What changed here? And how is this related to expm1?
https://codereview.chromium.org/465353002/diff/1/third_party/fdlibm/fdlibm.js#newcode513
third_party/fdlibm/fdlibm.js:513: (KLOG1P(4) + z * (KLOG1P(5) + z *
KLOG1P(6)))))));
This seems unrelated to expm1. And I can't see what actually changed
here..
https://codereview.chromium.org/465353002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
