lgtm
https://codereview.chromium.org/469743002/diff/40001/src/compiler/arm/instruction-selector-arm.cc
File src/compiler/arm/instruction-selector-arm.cc (right):
https://codereview.chromium.org/469743002/diff/40001/src/compiler/arm/instruction-selector-arm.cc#newcode151
src/compiler/arm/instruction-selector-arm.cc:151: if
(mshl.right().IsInt32Sub()) {
I am a bit confused - this looks like it is matching "const - const" -
should not constant propagation take care of this case (reducing it to
the previous case)?
Or is it here for users of RawMachineAssembler (which does not
optimize)?
https://codereview.chromium.org/469743002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
