Reviewers: jarin,
Message:
Committed patchset #1 manually as 23124 (tree was closed).
Description:
Really fix windows now.
[email protected]
Committed: https://code.google.com/p/v8/source/detail?r=23124
Please review this at https://codereview.chromium.org/472783002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+1, -19 lines):
M src/base/bits.h
Index: src/base/bits.h
diff --git a/src/base/bits.h b/src/base/bits.h
index
2cfce1edc2be934a30bc0965cf20c32119c9f871..ec0f5517a9d34d5ae593432749199b5ab9ec308f
100644
--- a/src/base/bits.h
+++ b/src/base/bits.h
@@ -14,35 +14,17 @@ namespace v8 {
namespace base {
namespace bits {
-#if V8_CC_MSVC
-
-#pragma intrinsic(_rotr)
-#pragma intrinsic(_rotr64)
-
-inline uint32_t RotateRight32(uint32_t value, uint32_t shift) {
- return _rotr(value, shift);
-}
-
-
-inline uint64_t RotateRight64(uint64_t value, uint32_t shift) {
- return _rotr64(value, shift);
-}
-
-#else // V8_CC_MSVC
-
inline uint32_t RotateRight32(uint32_t value, uint32_t shift) {
if (shift == 0) return value;
return (value >> shift) | (value << (32 - shift));
}
-inline uint64_t RotateRight64(uint64_t value, uint32_t shift) {
+inline uint64_t RotateRight64(uint64_t value, uint64_t shift) {
if (shift == 0) return value;
return (value >> shift) | (value << (64 - shift));
}
-#endif // V8_CC_MSVC
-
} // namespace bits
} // namespace base
} // namespace v8
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
