https://codereview.chromium.org/424973004/diff/120001/src/cpu-profiler.cc
File src/cpu-profiler.cc (right):
https://codereview.chromium.org/424973004/diff/120001/src/cpu-profiler.cc#newcode261
src/cpu-profiler.cc:261: if (shared->script()->IsScript()) {
Is it possible the shared->script() is not a Script? I see previously it
was not the case.
https://codereview.chromium.org/424973004/diff/120001/src/cpu-profiler.cc#newcode263
src/cpu-profiler.cc:263: script = Script::cast(shared->script());
Script::cast does the DCHECK internally so you don't really need to do
it here. Anyway if you still want to double check, could you please
write:
script = Script::cast(shared->script());
DCHECK(script);
https://codereview.chromium.org/424973004/diff/120001/src/profile-generator.h
File src/profile-generator.h (right):
https://codereview.chromium.org/424973004/diff/120001/src/profile-generator.h#newcode58
src/profile-generator.h:58:
pc_offset_map_.insert(std::make_pair(pc_offset, line));
a possible optimization: you don't need to bloat it with a new entry if
lower_bound for the pc_offset does already return line.
https://codereview.chromium.org/424973004/diff/120001/test/cctest/test-cpu-profiler.cc
File test/cctest/test-cpu-profiler.cc (right):
https://codereview.chromium.org/424973004/diff/120001/test/cctest/test-cpu-profiler.cc#newcode1134
test/cctest/test-cpu-profiler.cc:1134: CHECK_NE(NULL, line_info);
I've got the test failing at this line for ia32 target because there's
no POSITION reloc infos for the code.
https://codereview.chromium.org/424973004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
