Thanks arv, comments addressed.
marja, could you take a look at parser changes as well? Thanks!
https://codereview.chromium.org/480543002/diff/20001/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/480543002/diff/20001/src/ast.h#newcode2570
src/ast.h:2570: protected:
On 2014/08/15 19:41:07, arv wrote:
Empty line before protected.
Done.
https://codereview.chromium.org/480543002/diff/20001/src/full-codegen.h
File src/full-codegen.h (right):
https://codereview.chromium.org/480543002/diff/20001/src/full-codegen.h#newcode506
src/full-codegen.h:506:
On 2014/08/15 19:41:07, arv wrote:
revert?
Done.
https://codereview.chromium.org/480543002/diff/20001/src/preparser.h
File src/preparser.h (right):
https://codereview.chromium.org/480543002/diff/20001/src/preparser.h#newcode2401
src/preparser.h:2401: if (peek() == Token::SUPER) {
On 2014/08/15 19:41:07, arv wrote:
You can use Check here instead.
if (Check(Token::SUPER)) {
result = this->SuperReference(scope_, factory());
} else {
...
...but it seems like a lot of existing code uses peek+consume
Done.
https://codereview.chromium.org/480543002/diff/20001/src/scanner.cc
File src/scanner.cc (right):
https://codereview.chromium.org/480543002/diff/20001/src/scanner.cc#newcode910
src/scanner.cc:910: KEYWORD("class", Token::FUTURE_RESERVED_WORD)
\
On 2014/08/15 19:41:07, arv wrote:
I see your comment is not really reflecting this. Maybe just skip the
comment?
Updated comment to reflect reality of this patch.
https://codereview.chromium.org/480543002/diff/20001/src/scanner.h
File src/scanner.h (right):
https://codereview.chromium.org/480543002/diff/20001/src/scanner.h#newcode656
src/scanner.h:656: // Whether we scan 'super' and 'class' as keywords.
On 2014/08/15 19:41:07, arv wrote:
and eventually 'static'. I'll try to not forget to updated this
comment.
Updated comment to reflect reality of this patch.
https://codereview.chromium.org/480543002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
