Reviewers: Hannes Payer,

Description:
Version 3.27.34.14 (merged r23084)

Old space cannot be assumed to be iterable between GCs, even if swept precisely.

[email protected]
BUG=

Please review this at https://codereview.chromium.org/486693002/

SVN Base: https://v8.googlecode.com/svn/branches/3.27

Affected files (+6, -11 lines):
  M src/mark-compact.cc
  M src/version.cc


Index: src/mark-compact.cc
diff --git a/src/mark-compact.cc b/src/mark-compact.cc
index 61b1b54c7bd13c95acfe0b71f262e9dd6860c15f..30b97550cbe8545156f23e3e9efe1007c577cb15 100644
--- a/src/mark-compact.cc
+++ b/src/mark-compact.cc
@@ -2042,16 +2042,11 @@ int MarkCompactCollector::DiscoverAndPromoteBlackObjectsOnPage(
 static void DiscoverGreyObjectsInSpace(Heap* heap,
                                        MarkingDeque* marking_deque,
                                        PagedSpace* space) {
-  if (!space->was_swept_conservatively()) {
-    HeapObjectIterator it(space);
-    DiscoverGreyObjectsWithIterator(heap, marking_deque, &it);
-  } else {
-    PageIterator it(space);
-    while (it.has_next()) {
-      Page* p = it.next();
-      DiscoverGreyObjectsOnPage(marking_deque, p);
-      if (marking_deque->IsFull()) return;
-    }
+  PageIterator it(space);
+  while (it.has_next()) {
+    Page* p = it.next();
+    DiscoverGreyObjectsOnPage(marking_deque, p);
+    if (marking_deque->IsFull()) return;
   }
 }

Index: src/version.cc
diff --git a/src/version.cc b/src/version.cc
index d1ebf16af16c2d2dad09355d3a6793168520d330..d6c5135551c0d3d8abd5066eb60283cf4714d9dc 100644
--- a/src/version.cc
+++ b/src/version.cc
@@ -35,7 +35,7 @@
 #define MAJOR_VERSION     3
 #define MINOR_VERSION     27
 #define BUILD_NUMBER      34
-#define PATCH_LEVEL       13
+#define PATCH_LEVEL       14
 // Use 1 for candidates and 0 otherwise.
 // (Boolean macro values are not supported by all preprocessors.)
 #define IS_CANDIDATE_VERSION 0


--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to