On 2014/08/19 10:46:14, rossberg wrote:
NOT LGTM
Exposing this function would allow embedders to create new internal
symbols
and
clobber logical names from this space, which might be in conflict with
our own
(present or future) uses. I intentionally did not expose this
functionality,
and
introduced the separate ForApi registry instead to be used by embedders.
To grant access to the JS-defined set of internal symbols, we should
probably
just export them directly, perhaps simply mirroring the JS-side interface.
(Alternatively, ForInternal could allow only well-known names to pass,
but I
don't think that's a more elegant solution.)
Done.
https://codereview.chromium.org/483173002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
