Revision: 23223
Author: [email protected]
Date: Wed Aug 20 09:43:00 2014 UTC
Log: Remove RegExp.$input.
[email protected], [email protected]
BUG=v8:3486
LOG=Y
Review URL: https://codereview.chromium.org/465273002
http://code.google.com/p/v8/source/detail?r=23223
Modified:
/branches/bleeding_edge/src/regexp.js
/branches/bleeding_edge/test/mjsunit/string-match.js
/branches/bleeding_edge/test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt
=======================================
--- /branches/bleeding_edge/src/regexp.js Mon Jul 14 14:05:30 2014 UTC
+++ /branches/bleeding_edge/src/regexp.js Wed Aug 20 09:43:00 2014 UTC
@@ -410,8 +410,6 @@
RegExpSetInput, DONT_DELETE);
%DefineAccessorPropertyUnchecked($RegExp, '$_', RegExpGetInput,
RegExpSetInput, DONT_ENUM |
DONT_DELETE);
- %DefineAccessorPropertyUnchecked($RegExp, '$input', RegExpGetInput,
- RegExpSetInput, DONT_ENUM |
DONT_DELETE);
// The properties multiline and $* are aliases for each other. When this
// value is set in SpiderMonkey, the value it is set to is coerced to a
=======================================
--- /branches/bleeding_edge/test/mjsunit/string-match.js Thu Mar 27
12:32:27 2014 UTC
+++ /branches/bleeding_edge/test/mjsunit/string-match.js Wed Aug 20
09:43:00 2014 UTC
@@ -66,7 +66,6 @@
assertEquals(undefined, RegExp.$10, name + "-nocapture-10");
assertEquals(input, RegExp.input, name + "-input");
- assertEquals(input, RegExp.$input, name + "-$input");
assertEquals(input, RegExp.$_, name + "-$_");
assertEquals(preMatch, RegExp["$`"], name + "-$`");
=======================================
---
/branches/bleeding_edge/test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt
Thu Aug 7 17:57:27 2014 UTC
+++
/branches/bleeding_edge/test/webkit/fast/js/Object-getOwnPropertyNames-expected.txt
Wed Aug 20 09:43:00 2014 UTC
@@ -77,7 +77,7 @@
PASS getSortedOwnPropertyNames(Number.prototype) is
['constructor', 'toExponential', 'toFixed', 'toLocaleString', 'toPrecision', 'toString', 'valueOf']
PASS getSortedOwnPropertyNames(Date) is
['UTC', 'arguments', 'caller', 'length', 'name', 'now', 'parse', 'prototype']
PASS getSortedOwnPropertyNames(Date.prototype) is
['constructor', 'getDate', 'getDay', 'getFullYear', 'getHours', 'getMilliseconds', 'getMinutes', 'getMonth', 'getSeconds', 'getTime', 'getTimezoneOffset', 'getUTCDate', 'getUTCDay', 'getUTCFullYear', 'getUTCHours', 'getUTCMilliseconds', 'getUTCMinutes', 'getUTCMonth', 'getUTCSeconds', 'getYear', 'setDate', 'setFullYear', 'setHours', 'setMilliseconds', 'setMinutes', 'setMonth', 'setSeconds', 'setTime', 'setUTCDate', 'setUTCFullYear', 'setUTCHours', 'setUTCMilliseconds', 'setUTCMinutes', 'setUTCMonth', 'setUTCSeconds', 'setYear', 'toDateString', 'toGMTString', 'toISOString', 'toJSON', 'toLocaleDateString', 'toLocaleString', 'toLocaleTimeString', 'toString', 'toTimeString', 'toUTCString', 'valueOf']
-FAIL getSortedOwnPropertyNames(RegExp) should be
$&,$',$*,$+,$1,$2,$3,$4,$5,$6,$7,$8,$9,$_,$`,arguments,caller,input,lastMatch,lastParen,leftContext,length,multiline,name,prototype,rightContext.
Was
$&,$',$*,$+,$1,$2,$3,$4,$5,$6,$7,$8,$9,$_,$`,$input,arguments,caller,input,lastMatch,lastParen,leftContext,length,multiline,name,prototype,rightContext.
+PASS getSortedOwnPropertyNames(RegExp) is
['$&', "$'", '$*', '$+', '$1', '$2', '$3', '$4', '$5', '$6', '$7', '$8', '$9', '$_', '$`', 'arguments', 'caller', 'input', 'lastMatch', 'lastParen', 'leftContext', 'length', 'multiline', 'name', 'prototype', 'rightContext']
PASS getSortedOwnPropertyNames(RegExp.prototype) is
['compile', 'constructor', 'exec', 'global', 'ignoreCase', 'lastIndex', 'multiline', 'source', 'test', 'toString']
PASS getSortedOwnPropertyNames(Error) is
['arguments', 'caller', 'captureStackTrace', 'length', 'name', 'prototype', 'stackTraceLimit']
PASS getSortedOwnPropertyNames(Error.prototype) is
['constructor', 'message', 'name', 'toString']
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
