Reviewers: Jakob,
Message:
PTAL
Description:
Delete dead GetType from elements accessors
BUG=
Please review this at https://codereview.chromium.org/489033002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+0, -81 lines):
M src/elements.h
M src/elements.cc
Index: src/elements.cc
diff --git a/src/elements.cc b/src/elements.cc
index
945a9e7f6e1a95a50b729f127509d21af7d3dd35..c95ca5da055cc29b104414792e37ae7fbf61b420
100644
--- a/src/elements.cc
+++ b/src/elements.cc
@@ -653,28 +653,6 @@ class ElementsAccessorBase : public ElementsAccessor {
? ABSENT : NONE;
}
- MUST_USE_RESULT virtual PropertyType GetType(
- Handle<Object> receiver,
- Handle<JSObject> holder,
- uint32_t key,
- Handle<FixedArrayBase> backing_store) V8_FINAL V8_OVERRIDE {
- return ElementsAccessorSubclass::GetTypeImpl(
- receiver, holder, key, backing_store);
- }
-
- MUST_USE_RESULT static PropertyType GetTypeImpl(
- Handle<Object> receiver,
- Handle<JSObject> obj,
- uint32_t key,
- Handle<FixedArrayBase> backing_store) {
- if (key >= ElementsAccessorSubclass::GetCapacityImpl(backing_store)) {
- return NONEXISTENT;
- }
- return
- Handle<BackingStore>::cast(backing_store)->is_the_hole(key)
- ? NONEXISTENT : FIELD;
- }
-
MUST_USE_RESULT virtual MaybeHandle<AccessorPair> GetAccessorPair(
Handle<Object> receiver,
Handle<JSObject> holder,
@@ -1310,16 +1288,6 @@ class TypedElementsAccessor
? NONE : ABSENT;
}
- MUST_USE_RESULT static PropertyType GetTypeImpl(
- Handle<Object> receiver,
- Handle<JSObject> obj,
- uint32_t key,
- Handle<FixedArrayBase> backing_store) {
- return
- key < AccessorClass::GetCapacityImpl(backing_store)
- ? FIELD : NONEXISTENT;
- }
-
MUST_USE_RESULT static MaybeHandle<Object> SetLengthImpl(
Handle<JSObject> obj,
Handle<Object> length,
@@ -1530,20 +1498,6 @@ class DictionaryElementsAccessor
return ABSENT;
}
- MUST_USE_RESULT static PropertyType GetTypeImpl(
- Handle<Object> receiver,
- Handle<JSObject> obj,
- uint32_t key,
- Handle<FixedArrayBase> store) {
- Handle<SeededNumberDictionary> backing_store =
- Handle<SeededNumberDictionary>::cast(store);
- int entry = backing_store->FindEntry(key);
- if (entry != SeededNumberDictionary::kNotFound) {
- return backing_store->DetailsAt(entry).type();
- }
- return NONEXISTENT;
- }
-
MUST_USE_RESULT static MaybeHandle<AccessorPair> GetAccessorPairImpl(
Handle<Object> receiver,
Handle<JSObject> obj,
@@ -1648,23 +1602,6 @@ class SloppyArgumentsElementsAccessor : public
ElementsAccessorBase<
}
}
- MUST_USE_RESULT static PropertyType GetTypeImpl(
- Handle<Object> receiver,
- Handle<JSObject> obj,
- uint32_t key,
- Handle<FixedArrayBase> parameters) {
- Handle<FixedArray> parameter_map =
Handle<FixedArray>::cast(parameters);
- Handle<Object> probe = GetParameterMapArg(obj, parameter_map, key);
- if (!probe->IsTheHole()) {
- return FIELD;
- } else {
- // If not aliased, check the arguments.
- Handle<FixedArray>
arguments(FixedArray::cast(parameter_map->get(1)));
- return ElementsAccessor::ForArray(arguments)->GetType(
- receiver, obj, key, arguments);
- }
- }
-
MUST_USE_RESULT static MaybeHandle<AccessorPair> GetAccessorPairImpl(
Handle<Object> receiver,
Handle<JSObject> obj,
Index: src/elements.h
diff --git a/src/elements.h b/src/elements.h
index
3496a644aa5818f9929b81bff8c747cd5b3ae22a..d0bddf982d7934cf7a18e08ed08e419a4e136595
100644
--- a/src/elements.h
+++ b/src/elements.h
@@ -81,24 +81,6 @@ class ElementsAccessor {
return GetAttributes(receiver, holder, key,
handle(holder->elements()));
}
- // Returns an element's type, or NONEXISTENT if there is no such
- // element. This method doesn't iterate up the prototype chain. The
caller
- // can optionally pass in the backing store to use for the check, which
must
- // be compatible with the ElementsKind of the ElementsAccessor. If
- // backing_store is NULL, the holder->elements() is used as the backing
store.
- MUST_USE_RESULT virtual PropertyType GetType(
- Handle<Object> receiver,
- Handle<JSObject> holder,
- uint32_t key,
- Handle<FixedArrayBase> backing_store) = 0;
-
- MUST_USE_RESULT inline PropertyType GetType(
- Handle<Object> receiver,
- Handle<JSObject> holder,
- uint32_t key) {
- return GetType(receiver, holder, key, handle(holder->elements()));
- }
-
// Returns an element's accessors, or NULL if the element does not exist
or
// is plain. This method doesn't iterate up the prototype chain. The
caller
// can optionally pass in the backing store to use for the check, which
must
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
