Reviewers: Hannes Payer,
Description:
Fix implementation of bit count functions.
The bit counting functions provided by CompilerIntrinsics were undefined
for zero, which was easily overlooked and unsafe in general. Also their
implementation was kinda hacky and mostly untested. Fixed the
implementation and moved the functions to base/bits.h.
TEST=base-unittests,cctest,compiler-unittests,mjsunit
[email protected]
Please review this at https://codereview.chromium.org/494633002/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+137, -114 lines):
M include/v8config.h
M src/base/bits.h
D src/compiler-intrinsics.h
M src/compiler/arm/instruction-selector-arm.cc
M src/data-flow.h
M src/data-flow.cc
M src/frames.cc
M src/heap/mark-compact.h
M src/heap/mark-compact.cc
M src/hydrogen-instructions.cc
M src/mips/simulator-mips.cc
M src/mips64/simulator-mips64.cc
M test/base-unittests/bits-unittest.cc
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
