Reviewers: Yang,
Message:
PTAL
Description:
Return empty handle if GetPropertyByLookup has no result.
BUG=
Please review this at https://codereview.chromium.org/494583003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+3, -3 lines):
M src/api.cc
Index: src/api.cc
diff --git a/src/api.cc b/src/api.cc
index
69a5062965dd76e3c5c8e6e1b876a965df1e54e7..79cf36c794b793023ca8cd13ae7242879e1bff02
100644
--- a/src/api.cc
+++ b/src/api.cc
@@ -3571,7 +3571,8 @@ static Local<Value>
GetPropertyByLookup(i::LookupIterator* it) {
has_pending_exception = !i::Object::GetProperty(it).ToHandle(&result);
EXCEPTION_BAILOUT_CHECK(it->isolate(), Local<Value>());
- return Utils::ToLocal(result);
+ if (it->IsFound()) return Utils::ToLocal(result);
+ return Local<Value>();
}
@@ -3599,8 +3600,7 @@ Local<Value>
v8::Object::GetRealNamedProperty(Handle<String> key) {
ENTER_V8(isolate);
i::Handle<i::JSObject> self_obj = Utils::OpenHandle(this);
i::Handle<i::String> key_obj = Utils::OpenHandle(*key);
- i::LookupIterator it(self_obj, key_obj,
- i::LookupIterator::CHECK_DERIVED_PROPERTY);
+ i::LookupIterator it(self_obj, key_obj,
i::LookupIterator::CHECK_PROPERTY);
return GetPropertyByLookup(&it);
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
