Revision: 23241
Author: [email protected]
Date: Wed Aug 20 14:40:53 2014 UTC
Log: Modify SizeOfFirstPage to take ool constant pool into account.
The OOL constant pool places constants in the old pointer space rather than
the code space
which makes test-heap/ReleaseOverReservedPages fail. Modify SizeOfFirstPage
to
increase the initial size of old-pointer space by the size of the constant
pool and
decrease the code space by a corresponding amount.
[email protected]
Review URL: https://codereview.chromium.org/479553002
http://code.google.com/p/v8/source/detail?r=23241
Modified:
/branches/bleeding_edge/src/heap/spaces.cc
=======================================
--- /branches/bleeding_edge/src/heap/spaces.cc Mon Aug 11 13:45:00 2014 UTC
+++ /branches/bleeding_edge/src/heap/spaces.cc Wed Aug 20 14:40:53 2014 UTC
@@ -990,10 +990,13 @@
intptr_t PagedSpace::SizeOfFirstPage() {
+ // If using an ool constant pool then transfer the constant pool
allowance
+ // from the code space to the old pointer space.
+ static const int constant_pool_delta = FLAG_enable_ool_constant_pool ?
48 : 0;
int size = 0;
switch (identity()) {
case OLD_POINTER_SPACE:
- size = 112 * kPointerSize * KB;
+ size = (96 + constant_pool_delta) * kPointerSize * KB;
break;
case OLD_DATA_SPACE:
size = 192 * KB;
@@ -1015,9 +1018,9 @@
// upgraded to handle small pages.
size = AreaSize();
} else {
- size =
- RoundUp(480 * KB * FullCodeGenerator::kBootCodeSizeMultiplier
/ 100,
- kPointerSize);
+ size = RoundUp((480 - constant_pool_delta) * KB *
+ FullCodeGenerator::kBootCodeSizeMultiplier /
100,
+ kPointerSize);
}
break;
}
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
