LGTM
https://codereview.chromium.org/491023002/diff/1/test/cctest/test-api.cc
File test/cctest/test-api.cc (left):
https://codereview.chromium.org/491023002/diff/1/test/cctest/test-api.cc#oldcode21727
test/cctest/test-api.cc:21727: context0->Global()->Set(v8_str("x"),
v8_num(42));
On 2014/08/21 07:02:55, Toon Verwaest wrote:
On 2014/08/21 06:08:20, Yang wrote:
> Is this intentional? Why?
Because below it's calling into %AddNamedProperty, which due to my
changes in
the LookupIterator to look behind the JSGlobalProxy into the
JSGlobalObject, now
fails with a runtime assert that the property shouldn't exist yet.
Plus given
that all should result in AccessCheck failure, it doesn't really make
a
difference whether or not the property is there.
Acknowledged.
https://codereview.chromium.org/491023002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
