I'm really worried about the lack of test coverage for the ast graph
builder.
That'll bite us soon.
https://codereview.chromium.org/492203002/diff/20001/src/compiler/instruction-selector-impl.h
File src/compiler/instruction-selector-impl.h (right):
https://codereview.chromium.org/492203002/diff/20001/src/compiler/instruction-selector-impl.h#newcode354
src/compiler/instruction-selector-impl.h:354: std::vector<Node*>
output_nodes;
Can we allocate in the Zone instead? I.e. use zone_allocator<Node*>
instead of the default allocator?
https://codereview.chromium.org/492203002/diff/20001/src/compiler/instruction-selector-impl.h#newcode359
src/compiler/instruction-selector-impl.h:359: int input_count() { return
descriptor->InputCount(); }
const
https://codereview.chromium.org/492203002/diff/20001/src/compiler/instruction-selector-impl.h#newcode361
src/compiler/instruction-selector-impl.h:361: int frame_state_count() {
return descriptor->FrameStateCount(); }
const
https://codereview.chromium.org/492203002/diff/20001/src/compiler/instruction-selector-impl.h#newcode363
src/compiler/instruction-selector-impl.h:363: int
frame_state_value_count() {
const
https://codereview.chromium.org/492203002/diff/20001/src/compiler/instruction-selector.cc
File src/compiler/instruction-selector.cc (right):
https://codereview.chromium.org/492203002/diff/20001/src/compiler/instruction-selector.cc#newcode1039
src/compiler/instruction-selector.cc:1039: Node* state,
std::vector<InstructionOperand*>* inputs,
I don't like hardcoding the std::vector here. But honestly I don't know
how to refactor this method in a sane fashion currently...
https://codereview.chromium.org/492203002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
