On 2014/08/21 09:03:17, Hannes Payer wrote:
https://codereview.chromium.org/479113004/diff/20001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):
https://codereview.chromium.org/479113004/diff/20001/src/heap/mark-compact.cc#newcode3303
src/heap/mark-compact.cc:3303: static int SweepPrecisely(PagedSpace*
space,
FreeList* free_list, Page* p,
On 2014/08/21 08:29:12, jarin wrote:
> How about renaming to just "Sweep"?
Done.
https://codereview.chromium.org/479113004/diff/20001/src/heap/mark-compact.h
File src/heap/mark-compact.h (left):
https://codereview.chromium.org/479113004/diff/20001/src/heap/mark-compact.h#oldcode698
src/heap/mark-compact.h:698: bool sweep_precisely_;
On 2014/08/21 08:29:12, jarin wrote:
> Is this flag still needed?
Done.
lgtm. Very nice cleanup.
I am wondering whether we should also rename CONCURRENT_PRECISE ->
CONCURRENT_SWEEPING, PARALLEL_PRECISE -> PARALLEL_SWEEPING, PRECISE ->
SEQUENTIAL_SWEEPING.
https://codereview.chromium.org/479113004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
