LGTM with comments:
https://codereview.chromium.org/485273004/diff/1/test/base-unittests/testcfg.py
File test/base-unittests/testcfg.py (right):
https://codereview.chromium.org/485273004/diff/1/test/base-unittests/testcfg.py#newcode35
test/base-unittests/testcfg.py:35: elif test_case:
How about:
elif test_case and test_desc:
Otherwise you might get an empty line concatenated to the test_case.
https://codereview.chromium.org/485273004/diff/1/test/compiler-unittests/testcfg.py
File test/compiler-unittests/testcfg.py (right):
https://codereview.chromium.org/485273004/diff/1/test/compiler-unittests/testcfg.py#newcode10
test/compiler-unittests/testcfg.py:10: from testrunner.local import
utils
Maybe extract parsing into utils (as top-level method).
https://codereview.chromium.org/485273004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
