On 2014/08/21 11:13:04, ulan wrote:
lgtm
https://codereview.chromium.org/494053002/diff/1/src/arm64/lithium-codegen-arm64.cc
File src/arm64/lithium-codegen-arm64.cc (right):
https://codereview.chromium.org/494053002/diff/1/src/arm64/lithium-codegen-arm64.cc#newcode4941
src/arm64/lithium-codegen-arm64.cc:4941: UseScratchRegisterScope
temps(masm());
Didn't we want to reduce usage of scratch registers in lithium? :) One the
other
hand, it's nice to safe one register for SAR/SHL/SHR. Not sure if this an
improvement, but don't mind landing this.
Indeed! We've debated it quite a bit over the last year or so. Since the
introduction of UseScratchRegisterScope, it's a lot safer, since exhausting
the
scratch register pool will trigger fatal assertions (even in release mode).
We
aren't exactly short of registers in the arm64 back-end, but there are other
Lithium instructions where we use UseScratchRegisterScope for special cases,
rather than allocate a dedicated scratch register (or duplicate the
selection
logic).
https://codereview.chromium.org/494053002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
