On 2014/08/21 16:56:34, caitp wrote:

https://codereview.chromium.org/363833006/diff/230001/test/mjsunit/harmony/array-from.js
File test/mjsunit/harmony/array-from.js (right):


https://codereview.chromium.org/363833006/diff/230001/test/mjsunit/harmony/array-from.js#newcode22
test/mjsunit/harmony/array-from.js:22: //
assertArrayLikeEquals(Array.from.call(thisArg, generator()), ['a', 'b', 'c'],
constructor);
It looks like one of the flags added for mjsunit tests is breaking this:

It breaks with the following configuration:

out/x64.release/d8 --random-seed=454874028 --turbo-filter=* --always-opt
--nohard-abort --nodead-code-elimination --nofold-constants --harmony-arrays
--harmony-generators
V8 version 3.29.13 (candidate) [console: dumb]
d8> (function() { function* generator() { yield '1'; yield '2'; yield '3'; }
return Array.from(generator()); })()


#
# Fatal error in , line 0
# unimplemented code
#

==== C stack trace ===============================

  1: ??
  2: ??
  3: ??

But if you just pass --harmony-arrays --harmony-generators, it works as
expected

Probably related to TurboFan. I see other generator tests being disabled:

https://codereview.chromium.org/342453002/diff/70008/test/mjsunit/mjsunit.status

https://codereview.chromium.org/363833006/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to