Reviewers: jarin,
Description:
Pacify GCmole.
[email protected]
Please review this at https://codereview.chromium.org/490423003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+20, -11 lines):
M test/cctest/test-dictionary.cc
M test/cctest/test-ordered-hash-table.cc
Index: test/cctest/test-dictionary.cc
diff --git a/test/cctest/test-dictionary.cc b/test/cctest/test-dictionary.cc
index
9a1914237fe185f841125051b7feaac12c180416..14e5d69d43714bba76b9e66a6c96026590f60b88
100644
--- a/test/cctest/test-dictionary.cc
+++ b/test/cctest/test-dictionary.cc
@@ -99,8 +99,8 @@ static void TestHashMap(Handle<HashMap> table) {
for (int i = 0; i < 100; i++) {
Handle<JSReceiver> key = factory->NewJSArray(7);
CHECK_EQ(table->Lookup(key), CcTest::heap()->the_hole_value());
- CHECK_EQ(key->GetIdentityHash(),
- CcTest::heap()->undefined_value());
+ Object* identity_hash = key->GetIdentityHash();
+ CHECK_EQ(identity_hash, CcTest::heap()->undefined_value());
}
}
Index: test/cctest/test-ordered-hash-table.cc
diff --git a/test/cctest/test-ordered-hash-table.cc
b/test/cctest/test-ordered-hash-table.cc
index
bb1e0145b5335946c095773b22f45cb20720e3c5..957893631759af3dd0329e029229bd6ead7e6dda
100644
--- a/test/cctest/test-ordered-hash-table.cc
+++ b/test/cctest/test-ordered-hash-table.cc
@@ -118,7 +118,8 @@ TEST(Map) {
CHECK(ordered_map->Lookup(obj)->IsTheHole());
ordered_map = OrderedHashMap::Put(ordered_map, obj, val);
CHECK_EQ(1, ordered_map->NumberOfElements());
- CHECK(ordered_map->Lookup(obj)->SameValue(*val));
+ Object* lookup = ordered_map->Lookup(obj);
+ CHECK(lookup->SameValue(*val));
bool was_present = false;
ordered_map = OrderedHashMap::Remove(ordered_map, obj, &was_present);
CHECK(was_present);
@@ -136,20 +137,28 @@ TEST(Map) {
ordered_map = OrderedHashMap::Put(ordered_map, obj2, val2);
ordered_map = OrderedHashMap::Put(ordered_map, obj3, val3);
CHECK_EQ(3, ordered_map->NumberOfElements());
- CHECK(ordered_map->Lookup(obj1)->SameValue(*val1));
- CHECK(ordered_map->Lookup(obj2)->SameValue(*val2));
- CHECK(ordered_map->Lookup(obj3)->SameValue(*val3));
+ lookup = ordered_map->Lookup(obj1);
+ CHECK(lookup->SameValue(*val1));
+ lookup = ordered_map->Lookup(obj2);
+ CHECK(lookup->SameValue(*val2));
+ lookup = ordered_map->Lookup(obj3);
+ CHECK(lookup->SameValue(*val3));
// Test growth
ordered_map = OrderedHashMap::Put(ordered_map, obj, val);
Handle<JSObject> obj4 = factory->NewJSObjectFromMap(map);
Handle<JSObject> val4 = factory->NewJSObjectFromMap(map);
ordered_map = OrderedHashMap::Put(ordered_map, obj4, val4);
- CHECK(ordered_map->Lookup(obj)->SameValue(*val));
- CHECK(ordered_map->Lookup(obj1)->SameValue(*val1));
- CHECK(ordered_map->Lookup(obj2)->SameValue(*val2));
- CHECK(ordered_map->Lookup(obj3)->SameValue(*val3));
- CHECK(ordered_map->Lookup(obj4)->SameValue(*val4));
+ lookup = ordered_map->Lookup(obj);
+ CHECK(lookup->SameValue(*val));
+ lookup = ordered_map->Lookup(obj1);
+ CHECK(lookup->SameValue(*val1));
+ lookup = ordered_map->Lookup(obj2);
+ CHECK(lookup->SameValue(*val2));
+ lookup = ordered_map->Lookup(obj3);
+ CHECK(lookup->SameValue(*val3));
+ lookup = ordered_map->Lookup(obj4);
+ CHECK(lookup->SameValue(*val4));
CHECK_EQ(5, ordered_map->NumberOfElements());
CHECK_EQ(4, ordered_map->NumberOfBuckets());
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
