thx for review
https://codereview.chromium.org/490173002/diff/100001/src/ast.h
File src/ast.h (right):
https://codereview.chromium.org/490173002/diff/100001/src/ast.h#newcode188
src/ast.h:188: explicit IdGen(int id) : id_(id) {}
On 2014/08/22 08:47:58, rossberg wrote:
Nit: could also merge the two constructors into one with default
argument 0.
Done.
https://codereview.chromium.org/490173002/diff/100001/src/parser.cc
File src/parser.cc (right):
https://codereview.chromium.org/490173002/diff/100001/src/parser.cc#newcode349
src/parser.cc:349: saved_ast_node_id_gen_ =
*(parser_->ast_node_id_gen_);
On 2014/08/22 08:47:58, rossberg wrote:
Nit: some places left with redundant parens
Done.
https://codereview.chromium.org/490173002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
