https://codereview.chromium.org/479693004/diff/40001/src/heap/gc-idle-time-handler.cc
File src/heap/gc-idle-time-handler.cc (right):
https://codereview.chromium.org/479693004/diff/40001/src/heap/gc-idle-time-handler.cc#newcode75
src/heap/gc-idle-time-handler.cc:75: if (heap_state.sweeping_in_progress
&&
On 2014/08/22 08:05:35, ulan wrote:
On the second thought, this check should be outside the "if
(!heap_state.can_start_incremental_marking)" branch.
Otherwise, we wait for sweepers only if it is not worth activating
incremental
marking.
Done.
https://codereview.chromium.org/479693004/diff/40001/src/heap/heap.cc
File src/heap/heap.cc (right):
https://codereview.chromium.org/479693004/diff/40001/src/heap/heap.cc#newcode4296
src/heap/heap.cc:4296: heap_state.incremental_marking_stopped =
incremental_marking()->IsStopped();
On 2014/08/22 08:05:35, ulan wrote:
incremental_marking has SWEEPING state, should we also check for this
state when
deciding to DO_FINALIZE_SWEEPING?
The SWEEPING state in incremental marking is just set when we are about
to start incremental marking, but are blocked by the sweeper threads.
Hence, it does not really fit the condition.
https://codereview.chromium.org/479693004/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
