Reviewers: Yang,
Message:
PTAL
Description:
Change return-type of SetDataProperty to Handle.
BUG=
Please review this at https://codereview.chromium.org/494733005/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+4, -4 lines):
M src/objects.h
M src/objects.cc
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index
6e67b5a812bd56382693322435a6b0940dc87ad9..f223b0fc9461a138fb0abd67d7bee22fcdea85b1
100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -2932,8 +2932,8 @@ MaybeHandle<Object>
Object::WriteToReadOnlyProperty(LookupIterator* it,
}
-MaybeHandle<Object> Object::SetDataProperty(LookupIterator* it,
- Handle<Object> value) {
+Handle<Object> Object::SetDataProperty(LookupIterator* it,
+ Handle<Object> value) {
// Proxies are handled on the WithHandler path. Other non-JSObjects
cannot
// have own properties.
Handle<JSObject> receiver = Handle<JSObject>::cast(it->GetReceiver());
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index
53b95d21803beca95c31a3721bb89f7d689503b6..3c814f2127a7c3b61e1cdcced83c6a060f7ddf63
100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -1486,8 +1486,8 @@ class Object {
StoreFromKeyed store_mode);
MUST_USE_RESULT static MaybeHandle<Object> WriteToReadOnlyProperty(
LookupIterator* it, Handle<Object> value, StrictMode strict_mode);
- MUST_USE_RESULT static MaybeHandle<Object> SetDataProperty(
- LookupIterator* it, Handle<Object> value);
+ static Handle<Object> SetDataProperty(LookupIterator* it,
+ Handle<Object> value);
MUST_USE_RESULT static MaybeHandle<Object> AddDataProperty(
LookupIterator* it, Handle<Object> value, PropertyAttributes
attributes,
StrictMode strict_mode, StoreFromKeyed store_mode);
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
