https://codereview.chromium.org/491303002/diff/1/src/compiler/verifier.cc
File src/compiler/verifier.cc (right):
https://codereview.chromium.org/491303002/diff/1/src/compiler/verifier.cc#newcode250
src/compiler/verifier.cc:250: static bool FindDominatingDef(Schedule*
schedule, Node* node,
On 2014/08/22 11:55:32, jarin wrote:
FindDominatingDef suggests that it returns the dominating def. How
about
HasDominatingDef?
Done.
https://codereview.chromium.org/491303002/diff/1/src/compiler/verifier.cc#newcode261
src/compiler/verifier.cc:261: use_pos = block->nodes_.size() - 1;
On 2014/08/22 11:55:31, jarin wrote:
I guess this will not compile on Win64. Perhaps use (reverse) iterator
instead
of int? Or cast...
Done.
https://codereview.chromium.org/491303002/diff/1/src/compiler/verifier.cc#newcode275
src/compiler/verifier.cc:275: use_pos = use_block->nodes_.size() - 1;
On 2014/08/22 11:55:31, jarin wrote:
Again, this will not compile on Win64.
Done.
https://codereview.chromium.org/491303002/diff/1/src/compiler/verifier.cc#newcode417
src/compiler/verifier.cc:417: // schedules don't have control inputs.
On 2014/08/22 11:55:31, jarin wrote:
Note: At some point we will have to fix RawMachineAssembler to produce
regular
graphs (connect control and effect inputs).
Yeah, I know.
https://codereview.chromium.org/491303002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
