On 2014/08/22 14:13:25, Fabrice de Gans wrote:
LTO merges all the flags at link time. v8 is built with -O2  (optimize for
speed) and that takes precedence over -Os (optimize for size), which we use in
the rest of Chromium.
So, essentially, the "-O2" option spills into the rest of the build. There's
no
"fix" for that as it's not a bug.
I hope the explanation in the file is clear enough.

https://codereview.chromium.org/497713002/diff/1/build/toolchain.gypi
File build/toolchain.gypi (right):


https://codereview.chromium.org/497713002/diff/1/build/toolchain.gypi#newcode247
build/toolchain.gypi:247: # Disable LTO for v8
On 2014/08/22 13:47:48, ulan wrote:
> Could you please expand this commet explaining why we need to disable it and
> when can we enable it? Maybe a link to a chromium issue?

Done.

Thanks, lgtm.

https://codereview.chromium.org/497713002/

--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
--- You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to