Reviewers: jarin,
Description:
Correctly forward-declare inline function headers in generic-node.h
[email protected]
Please review this at https://codereview.chromium.org/488363003/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+9, -6 lines):
M src/compiler/generic-node.h
M src/compiler/node-properties-inl.h
M src/compiler/simplified-operator-reducer.cc
M test/cctest/compiler/test-run-machops.cc
Index: src/compiler/generic-node.h
diff --git a/src/compiler/generic-node.h b/src/compiler/generic-node.h
index
aadee7611a7e0a3cd8192c2aff3a5aa6a29a1f12..0cfba72bc967253952fb5a355352e8afcf956a89
100644
--- a/src/compiler/generic-node.h
+++ b/src/compiler/generic-node.h
@@ -43,9 +43,9 @@ class GenericNode : public B {
S* InputAt(int index) const {
return static_cast<S*>(GetInputRecordPtr(index)->to);
}
- void ReplaceInput(int index, GenericNode* new_input);
- void AppendInput(Zone* zone, GenericNode* new_input);
- void InsertInput(Zone* zone, int index, GenericNode* new_input);
+ inline void ReplaceInput(int index, GenericNode* new_input);
+ inline void AppendInput(Zone* zone, GenericNode* new_input);
+ inline void InsertInput(Zone* zone, int index, GenericNode* new_input);
int UseCount() { return use_count_; }
S* UseAt(int index) {
@@ -59,7 +59,7 @@ class GenericNode : public B {
inline void ReplaceUses(GenericNode* replace_to);
template <class UnaryPredicate>
inline void ReplaceUsesIf(UnaryPredicate pred, GenericNode* replace_to);
- void RemoveAllInputs();
+ inline void RemoveAllInputs();
void TrimInputCount(int input_count);
@@ -127,8 +127,8 @@ class GenericNode : public B {
}
}
- void AppendUse(Use* use);
- void RemoveUse(Use* use);
+ inline void AppendUse(Use* use);
+ inline void RemoveUse(Use* use);
void* operator new(size_t, void* location) { return location; }
Index: src/compiler/node-properties-inl.h
diff --git a/src/compiler/node-properties-inl.h
b/src/compiler/node-properties-inl.h
index
00e66e7d3890c5d3d25981c0d6ed5bd8e45b29bd..bc52dfdb7519d6470a658e2729ab49ca7d32652c
100644
--- a/src/compiler/node-properties-inl.h
+++ b/src/compiler/node-properties-inl.h
@@ -8,6 +8,7 @@
#include "src/v8.h"
#include "src/compiler/common-operator.h"
+#include "src/compiler/generic-node-inl.h"
#include "src/compiler/node-properties.h"
#include "src/compiler/opcodes.h"
#include "src/compiler/operator.h"
Index: src/compiler/simplified-operator-reducer.cc
diff --git a/src/compiler/simplified-operator-reducer.cc
b/src/compiler/simplified-operator-reducer.cc
index
7909506df37ad37a0020248548613a2bf3663be9..05c2599e955efb09b50dd4b782151cc305487667
100644
--- a/src/compiler/simplified-operator-reducer.cc
+++ b/src/compiler/simplified-operator-reducer.cc
@@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "src/compiler/generic-node-inl.h"
#include "src/compiler/js-graph.h"
#include "src/compiler/node-matchers.h"
#include "src/compiler/simplified-operator-reducer.h"
Index: test/cctest/compiler/test-run-machops.cc
diff --git a/test/cctest/compiler/test-run-machops.cc
b/test/cctest/compiler/test-run-machops.cc
index
978842bf7953884020bec2cff2daf0f494c9df6d..2c7d16f10ad27b89a6ce42baae5bbbc4c6a7f868
100644
--- a/test/cctest/compiler/test-run-machops.cc
+++ b/test/cctest/compiler/test-run-machops.cc
@@ -6,6 +6,7 @@
#include <limits>
#include "src/base/bits.h"
+#include "src/compiler/generic-node-inl.h"
#include "test/cctest/cctest.h"
#include "test/cctest/compiler/codegen-tester.h"
#include "test/cctest/compiler/value-helper.h"
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
