Revision: 23343
Author: [email protected]
Date: Mon Aug 25 09:55:41 2014 UTC
Log: MIPS: Remove KeyedStoreIC::GenerateRuntimeSetProperty and move
Store::GenerateRuntimeSetProperty to the PropertyICCompiler.
Port r23311 (654ca86)
BUG=
[email protected]
Review URL: https://codereview.chromium.org/504743002
https://code.google.com/p/v8/source/detail?r=23343
Modified:
/branches/bleeding_edge/src/ic/mips/ic-compiler-mips.cc
/branches/bleeding_edge/src/ic/mips/ic-mips.cc
/branches/bleeding_edge/src/ic/mips64/ic-compiler-mips64.cc
/branches/bleeding_edge/src/ic/mips64/ic-mips64.cc
=======================================
--- /branches/bleeding_edge/src/ic/mips/ic-compiler-mips.cc Mon Aug 25
09:09:25 2014 UTC
+++ /branches/bleeding_edge/src/ic/mips/ic-compiler-mips.cc Mon Aug 25
09:55:41 2014 UTC
@@ -961,6 +961,19 @@
TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
}
+
+
+void PropertyICCompiler::GenerateRuntimeSetProperty(MacroAssembler* masm,
+ StrictMode
strict_mode) {
+ __ Push(StoreIC::ReceiverRegister(), StoreIC::NameRegister(),
+ StoreIC::ValueRegister());
+
+ __ li(a0, Operand(Smi::FromInt(strict_mode)));
+ __ Push(a0);
+
+ // Do tail-call to runtime routine.
+ __ TailCallRuntime(Runtime::kSetProperty, 4, 1);
+}
#undef __
=======================================
--- /branches/bleeding_edge/src/ic/mips/ic-mips.cc Mon Aug 25 09:09:25 2014
UTC
+++ /branches/bleeding_edge/src/ic/mips/ic-mips.cc Mon Aug 25 09:55:41 2014
UTC
@@ -9,6 +9,7 @@
#include "src/codegen.h"
#include "src/ic/ic.h"
+#include "src/ic/ic-compiler.h"
#include "src/ic/stub-cache.h"
namespace v8 {
@@ -685,17 +686,6 @@
__ bind(&miss);
GenerateMiss(masm);
}
-
-
-void KeyedStoreIC::GenerateRuntimeSetProperty(MacroAssembler* masm,
- StrictMode strict_mode) {
- // Push receiver, key and value for runtime call.
- __ Push(ReceiverRegister(), NameRegister(), ValueRegister());
- __ li(a0, Operand(Smi::FromInt(strict_mode))); // Strict mode.
- __ Push(a0);
-
- __ TailCallRuntime(Runtime::kSetProperty, 4, 1);
-}
static void KeyedStoreGenerateGenericHelper(
@@ -896,7 +886,7 @@
// a0: value.
// a1: key.
// a2: receiver.
- GenerateRuntimeSetProperty(masm, strict_mode);
+ PropertyICCompiler::GenerateRuntimeSetProperty(masm, strict_mode);
// Extra capacity case: Check if there is extra capacity to
// perform the store and update the length. Used for adding one
@@ -1063,18 +1053,6 @@
__ IncrementCounter(counters->store_normal_miss(), 1, t0, t1);
GenerateMiss(masm);
}
-
-
-void StoreIC::GenerateRuntimeSetProperty(MacroAssembler* masm,
- StrictMode strict_mode) {
- __ Push(ReceiverRegister(), NameRegister(), ValueRegister());
-
- __ li(a0, Operand(Smi::FromInt(strict_mode)));
- __ Push(a0);
-
- // Do tail-call to runtime routine.
- __ TailCallRuntime(Runtime::kSetProperty, 4, 1);
-}
#undef __
=======================================
--- /branches/bleeding_edge/src/ic/mips64/ic-compiler-mips64.cc Mon Aug 25
09:09:25 2014 UTC
+++ /branches/bleeding_edge/src/ic/mips64/ic-compiler-mips64.cc Mon Aug 25
09:55:41 2014 UTC
@@ -962,6 +962,19 @@
TailCallBuiltin(masm, Builtins::kKeyedLoadIC_Miss);
}
+
+
+void PropertyICCompiler::GenerateRuntimeSetProperty(MacroAssembler* masm,
+ StrictMode
strict_mode) {
+ __ Push(StoreIC::ReceiverRegister(), StoreIC::NameRegister(),
+ StoreIC::ValueRegister());
+
+ __ li(a0, Operand(Smi::FromInt(strict_mode)));
+ __ Push(a0);
+
+ // Do tail-call to runtime routine.
+ __ TailCallRuntime(Runtime::kSetProperty, 4, 1);
+}
#undef __
=======================================
--- /branches/bleeding_edge/src/ic/mips64/ic-mips64.cc Mon Aug 25 09:09:25
2014 UTC
+++ /branches/bleeding_edge/src/ic/mips64/ic-mips64.cc Mon Aug 25 09:55:41
2014 UTC
@@ -9,6 +9,7 @@
#include "src/codegen.h"
#include "src/ic/ic.h"
+#include "src/ic/ic-compiler.h"
#include "src/ic/stub-cache.h"
namespace v8 {
@@ -690,18 +691,6 @@
__ bind(&miss);
GenerateMiss(masm);
}
-
-
-void KeyedStoreIC::GenerateRuntimeSetProperty(MacroAssembler* masm,
- StrictMode strict_mode) {
- // Push receiver, key and value for runtime call.
- __ Push(ReceiverRegister(), NameRegister(), ValueRegister());
-
- __ li(a0, Operand(Smi::FromInt(strict_mode))); // Strict mode.
- __ Push(a0);
-
- __ TailCallRuntime(Runtime::kSetProperty, 4, 1);
-}
static void KeyedStoreGenerateGenericHelper(
@@ -906,7 +895,7 @@
// a0: value.
// a1: key.
// a2: receiver.
- GenerateRuntimeSetProperty(masm, strict_mode);
+ PropertyICCompiler::GenerateRuntimeSetProperty(masm, strict_mode);
// Extra capacity case: Check if there is extra capacity to
// perform the store and update the length. Used for adding one
@@ -1070,18 +1059,6 @@
__ IncrementCounter(counters->store_normal_miss(), 1, a4, a5);
GenerateMiss(masm);
}
-
-
-void StoreIC::GenerateRuntimeSetProperty(MacroAssembler* masm,
- StrictMode strict_mode) {
- __ Push(ReceiverRegister(), NameRegister(), ValueRegister());
-
- __ li(a0, Operand(Smi::FromInt(strict_mode)));
- __ Push(a0);
-
- // Do tail-call to runtime routine.
- __ TailCallRuntime(Runtime::kSetProperty, 4, 1);
-}
#undef __
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
