Reviewers: Weiliang, Toon Verwaest,
Message:
weiliang & Toon.
please review and commit this porting patch.
thanks.
Description:
X87: Move PropertyAccessCompiler and CallOptimization to their own files
port r23320.
orginal commit message:
Move PropertyAccessCompiler and CallOptimization to their own files
BUG=
Please review this at https://codereview.chromium.org/498183002/
SVN Base: https://chromium.googlesource.com/external/v8.git@bleeding_edge
Affected files (+4, -27 lines):
A + src/ic/x87/access-compiler-x87.cc
M src/ic/x87/ic-compiler-x87.cc
M tools/gyp/v8.gyp
Index: src/ic/x87/access-compiler-x87.cc
diff --git a/src/ic/ia32/access-compiler-ia32.cc
b/src/ic/x87/access-compiler-x87.cc
similarity index 95%
copy from src/ic/ia32/access-compiler-ia32.cc
copy to src/ic/x87/access-compiler-x87.cc
index
060406608ee1e3f95b2b0cc365b853e6b4dfab9b..d30c2573417a26baba328e559721c2362cf7723f
100644
--- a/src/ic/ia32/access-compiler-ia32.cc
+++ b/src/ic/x87/access-compiler-x87.cc
@@ -4,7 +4,7 @@
#include "src/v8.h"
-#if V8_TARGET_ARCH_IA32
+#if V8_TARGET_ARCH_X87
#include "src/ic/access-compiler.h"
@@ -41,4 +41,4 @@ Register*
PropertyAccessCompiler::store_calling_convention() {
}
} // namespace v8::internal
-#endif // V8_TARGET_ARCH_IA32
+#endif // V8_TARGET_ARCH_X87
Index: src/ic/x87/ic-compiler-x87.cc
diff --git a/src/ic/x87/ic-compiler-x87.cc b/src/ic/x87/ic-compiler-x87.cc
index
dab04fa9b25d04e84a1872d54addec6b6b55e684..5c68d545d8ef993535473fa3882f8545553e8cf2
100644
--- a/src/ic/x87/ic-compiler-x87.cc
+++ b/src/ic/x87/ic-compiler-x87.cc
@@ -6,6 +6,7 @@
#if V8_TARGET_ARCH_X87
+#include "src/ic/call-optimization.h"
#include "src/ic/ic-compiler.h"
namespace v8 {
@@ -206,12 +207,6 @@ void
PropertyHandlerCompiler::GenerateCheckPropertyCell(
}
-void PropertyAccessCompiler::GenerateTailCall(MacroAssembler* masm,
- Handle<Code> code) {
- __ jmp(code, RelocInfo::CODE_TARGET);
-}
-
-
#undef __
#define __ ACCESS_MASM(masm())
@@ -780,25 +775,6 @@ Handle<Code>
PropertyICCompiler::CompileKeyedStorePolymorphic(
}
-Register* PropertyAccessCompiler::load_calling_convention() {
- // receiver, name, scratch1, scratch2, scratch3, scratch4.
- Register receiver = LoadIC::ReceiverRegister();
- Register name = LoadIC::NameRegister();
- static Register registers[] = {receiver, name, ebx, eax, edi, no_reg};
- return registers;
-}
-
-
-Register* PropertyAccessCompiler::store_calling_convention() {
- // receiver, name, scratch1, scratch2, scratch3.
- Register receiver = StoreIC::ReceiverRegister();
- Register name = StoreIC::NameRegister();
- DCHECK(ebx.is(KeyedStoreIC::MapRegister()));
- static Register registers[] = {receiver, name, ebx, edi, no_reg};
- return registers;
-}
-
-
Register NamedStoreHandlerCompiler::value() { return
StoreIC::ValueRegister(); }
Index: tools/gyp/v8.gyp
diff --git a/tools/gyp/v8.gyp b/tools/gyp/v8.gyp
index
1579a0540c22124ed2c42f1b8c1fa39edd602ca3..bd045fd2d675b941dc2bae3dda2d1c5571b6b255
100644
--- a/tools/gyp/v8.gyp
+++ b/tools/gyp/v8.gyp
@@ -917,6 +917,7 @@
'../../src/x87/macro-assembler-x87.h',
'../../src/x87/regexp-macro-assembler-x87.cc',
'../../src/x87/regexp-macro-assembler-x87.h',
+ '../../src/ic/x87/access-compiler-x87.cc',
'../../src/ic/x87/ic-x87.cc',
'../../src/ic/x87/ic-compiler-x87.cc',
'../../src/ic/x87/stub-cache-x87.cc',
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
