Reviewers: Yang,
https://codereview.chromium.org/488993004/diff/1/src/objects.h
File src/objects.h (right):
https://codereview.chromium.org/488993004/diff/1/src/objects.h#newcode5962
src/objects.h:5962: enum { kGroupCount =
kAllocationSiteTransitionChangedGroup + 1 };
On 2014/08/25 12:12:43, Yang wrote:
does this have to be an enum though? Can it be simply a constant?
Fixed.
(I became accustomed to declaring constants like this via enums
recently)
Description:
Move kGroupCount out of DependencyGroup enum.
BUG=
Please review this at https://codereview.chromium.org/488993004/
SVN Base: https://v8.googlecode.com/svn/branches/bleeding_edge
Affected files (+5, -5 lines):
M src/objects.h
M src/objects.cc
Index: src/objects.cc
diff --git a/src/objects.cc b/src/objects.cc
index
307bcbf13cdc539eaf041e835fa97910e0caa34c..b03a407f0a100fbfea77246137be637c79e23118
100644
--- a/src/objects.cc
+++ b/src/objects.cc
@@ -11875,10 +11875,9 @@ const char*
DependentCode::DependencyGroupName(DependencyGroup group) {
return "allocation-site-tenuring-changed";
case kAllocationSiteTransitionChangedGroup:
return "allocation-site-transition-changed";
- default:
- UNREACHABLE();
- return "?";
}
+ UNREACHABLE();
+ return "?";
}
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index
d00941675789dbee0d2b7b132c5f051f34a741bd..7e639a944a37a083aec8166981705fef72a3d75c
100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -5956,10 +5956,11 @@ class DependentCode: public FixedArray {
kAllocationSiteTenuringChangedGroup,
// Group of code that depends on element transition information in
// AllocationSites not being changed.
- kAllocationSiteTransitionChangedGroup,
- kGroupCount = kAllocationSiteTransitionChangedGroup + 1
+ kAllocationSiteTransitionChangedGroup
};
+ static const int kGroupCount = kAllocationSiteTransitionChangedGroup + 1;
+
// Array for holding the index of the first code object of each group.
// The last element stores the total number of code objects.
class GroupStartIndexes {
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
