lgtm % comments
https://codereview.chromium.org/500023003/diff/20001/tools/push-to-trunk/releases.py
File tools/push-to-trunk/releases.py (right):
https://codereview.chromium.org/500023003/diff/20001/tools/push-to-trunk/releases.py#newcode50
tools/push-to-trunk/releases.py:50: DEPS_RE =
re.compile('^\\s*(?:(?:"|\')v8_revision(?:"|\'): (?:"|\')'
running regex on the DEPS file? :/
you can use r"""...""" to continue to do raw strings.
also i think ['"] works in place of (?:"|')
https://codereview.chromium.org/500023003/diff/20001/tools/push-to-trunk/releases.py#newcode378
tools/push-to-trunk/releases.py:378: if len(revision) > 6:
Reversing this make more sense
if revision.isdigit() and len(revision) < 8:
return revision
...{return git-svn}...
https://codereview.chromium.org/500023003/diff/20001/tools/push-to-trunk/releases.py#newcode382
tools/push-to-trunk/releases.py:382:
os.chdir(os.path.join(step["chrome_path"], "v8"))
I don't really like this, but seeing how the rest of the file uses this
convention it might be a lost cause...
https://codereview.chromium.org/500023003/diff/20001/tools/push-to-trunk/releases.py#newcode406
tools/push-to-trunk/releases.py:406: self.GitFetchOrigin()
You might have to either (1) rebase on current branch or (2) ensure
origin/master is checked out.
Unless you're just updating the clone to get the git-svn numbers, and
not fetching to get V8 HEAD, in which case ignore this comment.
https://codereview.chromium.org/500023003/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
