lgtm
where's roll-dep located?
https://codereview.chromium.org/504793002/diff/1/tools/push-to-trunk/chromium_roll.py
File tools/push-to-trunk/chromium_roll.py (right):
https://codereview.chromium.org/504793002/diff/1/tools/push-to-trunk/chromium_roll.py#newcode88
tools/push-to-trunk/chromium_roll.py:88: "roll-dep", "v8 %s" %
self["trunk_revision"]) is None:
nit: if foo() is None: -> if not foo(): to match chromium style
edit: okay scratch that, I see the Command() implementation >_<
https://codereview.chromium.org/504793002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
