A couple nits, and then LGTM when addressed.
https://codereview.chromium.org/498283002/diff/1/src/code-stubs.h
File src/code-stubs.h (right):
https://codereview.chromium.org/498283002/diff/1/src/code-stubs.h#newcode808
src/code-stubs.h:808: class ArgumentCountBits : public
BitField<ArgumentCountKey, 0, 2> {};
I think you can add a static assert somewhere that enum ArgumentCountKey
fits in two bits.
https://codereview.chromium.org/498283002/diff/1/src/code-stubs.h#newcode847
src/code-stubs.h:847: class ExponentTypeBits : public
BitField<ExponentType, 0, 2> {};
Same treatment here (protect against someone adding another enum value
to ExponentType without increasing # of bits).
https://codereview.chromium.org/498283002/
--
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
---
You received this message because you are subscribed to the Google Groups "v8-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
